FIx image load in paywall rendering validation #5264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2fbfdce.
…ing validation The animated transition was making image load be flaky in paywall rendering validation (sometimes the images were not appearing)
JayShortway
approved these changes
Jun 10, 2025
…endering validation when running RevenueCat tests
JayShortway
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The transition animation that happens when loading paywall images was making paywall rendering validation tests to be flaky: sometimes the images were not appearing or they appeared with transparency (i.e. the transition was not finished at the time of taking the snapshot).
Description
This PR removes the image load transition animation in paywalls when running in paywall rendering validation.