Skip to content

Trigger promotional offer callback from PromotionalOfferViewModel #5263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2025
Merged

Trigger promotional offer callback from PromotionalOfferViewModel #5263

merged 2 commits into from
Jun 10, 2025

Conversation

facumenzella
Copy link
Contributor

@facumenzella facumenzella commented Jun 10, 2025 •
edited
Loading

Motivation

While working on removing internal use of preference keys, I noticed this was not being triggered.

Description

  • Move action wrapper call to PromotionalOfferViewModel
  • delete unused BaseManageSubscriptionViewModel.handleDismissPromotionalOfferView
  • add missing test

@facumenzella facumenzella requested a review from vegaro June 10, 2025 13:36
vegaro
vegaro approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@vegaro vegaro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense! After that test feel free to merge 🙏

@emerge-tools Emerge Tools
Copy link

emerge-tools bot commented Jun 10, 2025 •
edited
Loading

📸 Snapshot Test

216 unchanged

Name Added Removed Modified Renamed Unchanged Errored Approval
RevenueCat
com.revenuecat.PaywallsTester		 0 0 0 0 216 0 N/A

🛸 Powered by Emerge Tools

@facumenzella
Copy link
Contributor Author

tests added @vegaro

@facumenzella facumenzella enabled auto-merge (squash) June 10, 2025 14:58
@facumenzella facumenzella merged commit dee5257 into main Jun 10, 2025
12 checks passed
@facumenzella facumenzella deleted the fix/trigger-action-onpromotionaloffer branch June 10, 2025 15:03
@RCGitBot RCGitBot mentioned this pull request Jun 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vegaro vegaro vegaro approved these changes

Assignees
No one assigned
Labels
feat:Customer Center pr:fix A bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@facumenzella @vegaro