Refactor PurchaseHistory to use PurchaseInformation #5260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 Snapshot Test20 modified, 196 unchanged
🛸 Powered by Emerge Tools |
facumenzella
commented
Jun 10, 2025
* Renamed isActive to isExpired * Add badge cancelled trial * missing default key * missing default key
* Add _spi(Internal) to costumer center * add missing spi * Add _spi(Internal) to costumer center * add extra spi * missing spi * missing spi * add missing spi
facumenzella
commented
Jun 12, 2025
RevenueCatUI/CustomerCenter/ViewModels/PurchaseHistory/PurchaseHistoryViewModel.swift
Show resolved
Hide resolved
vegaro
reviewed
Jun 12, 2025
RevenueCatUI/CustomerCenter/Data/PurchaseInformation+Mock.swift
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| #if DEBUG | ||
| @available(iOS 15.0, *) | ||
| struct PurchaseHistoryView_Previews: PreviewProvider { | ||
| static var previews: some View { | ||
| let customerInfo = CustomerInfoFixtures.customerInfo( |
There was a problem hiding this comment.
it looks like this isn't used?
There was a problem hiding this comment.
Removed brought it back to fix the preview e9abb6a
RevenueCatUI/CustomerCenter/Views/PurchaseHistory/PurchaseHistoryView.swift
Show resolved
Hide resolved
RevenueCatUI/CustomerCenter/ViewModels/PurchaseHistory/PurchaseHistoryViewModel.swift
Show resolved
Hide resolved
vegaro
reviewed
Jun 13, 2025
vegaro
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Simplify implementation, and use
PurchaseInformationin every screenDescription
PurchaseInfoand work withPurchaseInformationcard_store_promotionalfor RC Promos in card & history #5275Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-06-10.at.11.48.34.mp4