Refetch offerings when preferred locale is set #5511
Conversation
1e1d72c to
c8ff9b7
Compare
📸 Snapshot Test2 modified, 691 unchanged
🛸 Powered by Emerge Tools |
| if self.overridePreferredUILocaleRateLimiter.shouldProceed() { | ||
| // Refetches new offerings with preferred locale | ||
| self.getOfferings(fetchPolicy: .default, fetchCurrent: true) { _, _ in | ||
| // No-op | ||
| } | ||
| } |
There was a problem hiding this comment.
Perhaps we could trigger the getOfferings only when
self.systemInfo.preferredLocaleOverride != localeIt's the most basic comparison, but at least it guards against developers setting to the already-set preferred locale.
There was a problem hiding this comment.
I'd rather bump that responsibility to the networking layer, but I see that we are using an ephemeral session with no cache. And our e-tag cache isn't well suited for this… is there a reason we can't inject a flag to a request to use a non ephemeral session and set the cache policy to something really short like a minute?
There was a problem hiding this comment.
Is there a reason we can't inject a flag to a request to use a non ephemeral session and set the cache policy to something really short like a minute?
This is a question 🤔 I'm do not remember off the top of my head why we use the session and caching that we use. I used to know at one point but probably should understand again 🤷♂️
I'd rather bump that responsibility to the networking layer
I'll leave it here for now since it short circuits it right at the start without touching any other layers and so its explicit that we aren't doing any extra networking calls to our API
Motivation
Refetch current offerings (no cache) when preferred locale is set
Description
Use a rate limiter when attempting to fetch current offerings when setting preferred locale (2 times per minute)