Skip to content

Conversation

JZDesign
Copy link
Contributor

@JZDesign JZDesign commented Aug 20, 2025

Checklist

  • If applicable, unit tests
  • If applicable, create follow-up issues for purchases-android and hybrids

Motivation

Users want to be able to force the user to remain on the paywall for a short period of time so they don't reactively close the paywall immediately.

Description

Adds a transition type to the button component and renders that component with a transition if it's present

Copy link

emerge-tools bot commented Aug 20, 2025

3 builds increased size

Name Version Download Change Install Change Approval
RevenueCat
com.revenuecat.PaywallsTester
1.0 (1) 12.7 MB ⬆️ 32.8 kB (0.26%) 48.9 MB ⬆️ 160.4 kB (0.33%) N/A
RevenueCat
com.revenuecat.PaywallsTester.mac-catalyst-scaled-to-match-ipad
1.0 (1) 11.7 MB ⬆️ 38.6 kB (0.33%) 43.5 MB ⬆️ 151.4 kB (0.35%) N/A
RevenueCat
com.revenuecat.PaywallsTester.mac-catalyst-optimized-for-mac
1.0 (1) 11.7 MB ⬆️ 38.6 kB (0.33%) 43.5 MB ⬆️ 151.4 kB (0.35%) N/A

RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 160.4 kB (0.33%)
Total download size change: ⬆️ 32.8 kB (0.26%)

Largest size changes

Item Install Size Change
DYLD.String Table ⬆️ 65.1 kB
Code Signature ⬆️ 3.8 kB
DYLD.Exports ⬆️ 3.1 kB
Other ⬆️ 88.3 kB
View Treemap

Image of diff

RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester.mac-catalyst-scaled-to-match-ipad

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 151.4 kB (0.35%)
Total download size change: ⬆️ 38.6 kB (0.33%)

Largest size changes

Item Install Size Change
DYLD.String Table ⬆️ 58.4 kB
Code Signature ⬆️ 3.5 kB
DYLD.Exports ⬆️ 3.1 kB
RevenueCat.PaywallComponent.ButtonComponent.ButtonComponent ⬆️ 548 B
Other ⬆️ 85.8 kB
View Treemap

Image of diff

RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester.mac-catalyst-optimized-for-mac

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 151.4 kB (0.35%)
Total download size change: ⬆️ 38.6 kB (0.33%)

Largest size changes

Item Install Size Change
DYLD.String Table ⬆️ 58.4 kB
Code Signature ⬆️ 3.5 kB
DYLD.Exports ⬆️ 3.1 kB
RevenueCat.PaywallComponent.ButtonComponent.ButtonComponent ⬆️ 548 B
Other ⬆️ 85.8 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

Copy link

emerge-tools bot commented Aug 20, 2025

📸 Snapshot Test

2 modified, 691 unchanged

Name Added Removed Modified Renamed Unchanged Errored Approval
RevenueCat
com.revenuecat.PaywallsTester.mac-catalyst-optimized-for-mac
0 0 1 0 230 0 ✅ Approved
RevenueCat
com.revenuecat.PaywallsTester.mac-catalyst-scaled-to-match-ipad
0 0 1 0 230 0 ✅ Approved
RevenueCat
com.revenuecat.PaywallsTester
0 0 0 0 231 0 N/A

🛸 Powered by Emerge Tools

@JZDesign JZDesign added the pr:feat A new feature label Aug 21, 2025
@JZDesign JZDesign marked this pull request as ready for review August 22, 2025 16:18
@JZDesign
Copy link
Contributor Author

@RCGitBot please test

@JZDesign
Copy link
Contributor Author

@RCGitBot please test

@JZDesign JZDesign requested a review from a team August 26, 2025 18:19
Copy link
Contributor

@rickvdl rickvdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment :)

@JZDesign JZDesign requested a review from vegaro August 28, 2025 12:54
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might make more sense for TransitionView to be TransitionViewModifier? 🤔

Other than that, this is 💯

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: :shipit: :shipit:

@JZDesign JZDesign merged commit 728d4b1 into main Aug 29, 2025
12 checks passed
@JZDesign JZDesign deleted the jzdesign/mon-1193 branch August 29, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:feat A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants