-
Notifications
You must be signed in to change notification settings - Fork 382
MON-1193 Optional transitions (delayed back button) #5490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3 builds increased size
RevenueCat 1.0 (1)
|
Item | Install Size Change |
---|---|
DYLD.String Table | ⬆️ 65.1 kB |
Code Signature | ⬆️ 3.8 kB |
DYLD.Exports | ⬆️ 3.1 kB |
Other | ⬆️ 88.3 kB |
RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester.mac-catalyst-scaled-to-match-ipad
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 151.4 kB (0.35%)
Total download size change: ⬆️ 38.6 kB (0.33%)
Largest size changes
Item | Install Size Change |
---|---|
DYLD.String Table | ⬆️ 58.4 kB |
Code Signature | ⬆️ 3.5 kB |
DYLD.Exports | ⬆️ 3.1 kB |
RevenueCat.PaywallComponent.ButtonComponent.ButtonComponent | ⬆️ 548 B |
Other | ⬆️ 85.8 kB |
RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester.mac-catalyst-optimized-for-mac
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 151.4 kB (0.35%)
Total download size change: ⬆️ 38.6 kB (0.33%)
Largest size changes
Item | Install Size Change |
---|---|
DYLD.String Table | ⬆️ 58.4 kB |
Code Signature | ⬆️ 3.5 kB |
DYLD.Exports | ⬆️ 3.1 kB |
RevenueCat.PaywallComponent.ButtonComponent.ButtonComponent | ⬆️ 548 B |
Other | ⬆️ 85.8 kB |
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
📸 Snapshot Test2 modified, 691 unchanged
🛸 Powered by Emerge Tools |
@RCGitBot please test |
@RCGitBot please test |
Sources/Paywalls/Components/Transitions/PaywallTransition.swift
Outdated
Show resolved
Hide resolved
Sources/Paywalls/Components/Transitions/PaywallTransition.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment :)
RevenueCatUI/Templates/V2/Components/Transition/TransitionView.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might make more sense for TransitionView
to be TransitionViewModifier
? 🤔
Other than that, this is 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checklist
purchases-android
and hybridsMotivation
Users want to be able to force the user to remain on the paywall for a short period of time so they don't reactively close the paywall immediately.
Description
Adds a transition type to the button component and renders that component with a transition if it's present