Skip to content

Extend appTarget settings to pass custom settings #5470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2025
Merged

Extend appTarget settings to pass custom settings #5470

merged 1 commit into from
Sep 1, 2025
+17 −8

Conversation

facumenzella
Copy link
Contributor

Motivation

While going through the tuist set up once again, I noticed that testCustomEntitlementsComputation a project to test RevenueCat_CustomEntitlementComputation didn't have the settings.

Description

  • Extend appTarget to receive extra settingsDictionary
  • Tweak testCustomEntitlementsComputation to include it for the only target it has

@emerge-tools Emerge Tools
Copy link

emerge-tools bot commented Aug 13, 2025

📸 Snapshot Test

1 modified, 704 unchanged

Name Added Removed Modified Renamed Unchanged Errored Approval
RevenueCat
com.revenuecat.PaywallsTester.mac-catalyst-optimized-for-mac		 0 0 1 0 234 0 ⏳ Needs approval
RevenueCat
com.revenuecat.PaywallsTester		 0 0 0 0 235 0 N/A
RevenueCat
com.revenuecat.PaywallsTester.mac-catalyst-scaled-to-match-ipad		 0 0 0 0 235 0 N/A

🛸 Powered by Emerge Tools

ajpallares
ajpallares approved these changes Sep 1, 2025
View reviewed changes
Copy link
Member

@ajpallares ajpallares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just one comment about the Examples/testCustomEntitlementsComputation/testCustomEntitlementsComputation.xcodeproj file

...estCustomEntitlementsComputation/testCustomEntitlementsComputation.xcodeproj/project.pbxproj
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious. Is this file being used in CI at all? If not, perhaps we could remove it and/or always have tuist generate it?
Note that the .xcodeproj file is already gitignored

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right. I can do that in another PR

@facumenzella facumenzella merged commit c735850 into main Sep 1, 2025
12 checks passed
@facumenzella facumenzella deleted the feat/add-ENABLE_CUSTOM_ENTITLEMENT_COMPUTATION-testproject branch September 1, 2025 15:41
@facumenzella facumenzella mentioned this pull request Sep 1, 2025
Merged
@RCGitBot RCGitBot mentioned this pull request Sep 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajpallares ajpallares ajpallares approved these changes

Assignees
No one assigned
Labels
pr:other
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@facumenzella @ajpallares