Make TrialOrIntroEligibilityChecker @_spi public #5461
Merged
+20
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing it into `PaywallView`'s `init`
e234431 to
bad58c6
Compare
📸 Snapshot Test2 modified, 691 unchanged
🛸 Powered by Emerge Tools |
|
@RCGitBot please test |
JayShortway
approved these changes
Aug 12, 2025
| @@ -11,12 +11,15 @@ | |||
| // | |||
| // Created by Nacho Soto on 7/13/23. | |||
|
|
|||
| import Combine | |||
There was a problem hiding this comment.
Curious why this was needed?
There was a problem hiding this comment.
I think ObservableObject is part of Combine
There was a problem hiding this comment.
Yea, but we were already using that haha, which is what made me curious.
There was a problem hiding this comment.
Adding the @_spi(Internal) public to TrialOrIntroEligibilityChecker without import Combine triggered this warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow previewing intro trials in Paywall Previews in the RC app, we need to allow the app to inject its own
TrialOrIntroEligibilityChecker. That's why we're makingTrialOrIntroEligibilityChecker@_spipublic