Skip to content

Conversation

joshdholtz
Copy link
Member

@joshdholtz joshdholtz commented Aug 7, 2025

Summary

  • Modified PackageComponentView to conditionally wrap content in a Button based on whether it contains a purchase button
  • Added PurchaseButtonCollector to track presence of purchase buttons within components
  • Updated ViewModelFactory to propagate purchase button detection through component hierarchy
  • Package components with purchase buttons no longer get wrapped in an additional button layer

Changes

  • Added PurchaseButtonCollector class to track purchase button presence
  • Modified PackageComponentViewModel to include hasPurchaseButton property
  • Updated PackageComponentView to conditionally apply button wrapper based on purchase button presence
  • Propagated purchase button collector through all component view model creation methods

Test plan

  • Verify packages without purchase buttons still function as clickable selectors
  • Verify packages with purchase buttons don't have double button wrapping
  • Test package selection behavior in various paywall configurations
  • Ensure accessibility is maintained for both scenarios

🤖 Generated with Claude Code

closes #5458

@joshdholtz joshdholtz requested review from a team August 7, 2025 14:22
Copy link

emerge-tools bot commented Aug 7, 2025

📸 Snapshot Test

1 modified, 704 unchanged

Name Added Removed Modified Renamed Unchanged Errored Approval
RevenueCat
com.revenuecat.PaywallsTester.mac-catalyst-optimized-for-mac
0 0 0 0 235 0 N/A
RevenueCat
com.revenuecat.PaywallsTester
0 0 0 0 235 0 N/A
RevenueCat
com.revenuecat.PaywallsTester.mac-catalyst-scaled-to-match-ipad
0 0 1 0 234 0 ✅ Approved

🛸 Powered by Emerge Tools

@joshdholtz joshdholtz marked this pull request as ready for review August 10, 2025 13:54
@joshdholtz joshdholtz merged commit b1bb834 into main Aug 10, 2025
12 checks passed
@joshdholtz joshdholtz deleted the paywalls-disable-package-highlight-with-purchase-button branch August 10, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants