Add offer code redemption support to paywall buttons #5437

joshdholtz · 2025-07-30T15:16:26Z

Summary

Add new offerCode destination type to PaywallButtonComponent with proper encoding/decoding
Implement navigation handling in ButtonComponentView to present the system offer code redemption sheet
Add cache invalidation after offer code redemption to ensure customer info is refreshed

Test plan

Verify paywall buttons can be configured with offer_code destination in JSON
Test that tapping a button with offer code destination presents the system redemption sheet
Confirm customer info cache is invalidated after offer code redemption
Ensure existing button functionality remains unaffected

🤖 Generated with Claude Code

- Add offerCode destination type to PaywallButtonComponent - Implement offer code redemption sheet handling in ButtonComponentView - Add offerCodeRedemptionSheet navigation destination to ButtonComponentViewModel - Invalidate customer info cache after offer code redemption 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

tonidero

Just a question but looking great!!

tonidero · 2025-07-31T12:46:05Z

RevenueCatUI/Templates/V2/Components/Button/ButtonComponentView.swift

        }
    }

+    private func openCodeREDemptionSheet() {
+        Purchases.shared.presentCodeRedemptionSheet()


Not part of this PR, since I see we were already calling Purchases.shared when invalidating the customer info when opening a web paywall link... But I do think these methods should ideally belong to the view model, not to the view.

Besides what Toni says, we should probably avoid calling Purchases.shared directly and go through the existing PurchaseHandler instance instead (the person working on the RC app will later thank us for this 😄).

As talked with Josh privately, removing the Purchases.shared here is more intricate than it looks. So it'll be tackled in a future PR (thank you Swift protocols for not allowing @Availability checks in your methods)

tonidero · 2025-07-31T12:49:02Z

RevenueCatUI/View+PresentPaywall.swift

+            await self.updateCustomerInfo()
+        }
+        .onChange(of: scenePhase) { newPhase in
+            // Used when Offer Code Redemption sheet dismisses


Correct me if I'm wrong but would this be called every time the app becomes active even if it didn't go through the offer code redemption sheet, but something else? I guess it's not a huge deal... but we should be careful about invalidating customer info too often IMO, since it could lead to a user temporarily losing entitlements momentarily. If you can confirm this would only happen on offer code redemption sheet dismissal, I'm ok with this :)

Good point from Toni here. The code currently only checks when the scenePhase passes to active. Perhaps we could restrict this to make it closer to the "when Offer Code Redemption sheet dismisses" event by using https://developer.apple.com/documentation/swiftui/view/onchange(of:initial:_:)-4psgg and only do updateCustomerInfo() if newPhase == .active && oldPhase == .inactive (this way we avoid calling it when coming from the .background)

ajpallares

I have a couple of more comments, building on Toni's

ajpallares · 2025-07-31T14:17:01Z

RevenueCatUI/Templates/V2/Components/Button/ButtonComponentView.swift

        }
    }

+    private func openCodeREDemptionSheet() {
+        Purchases.shared.presentCodeRedemptionSheet()


Besides what Toni says, we should probably avoid calling Purchases.shared directly and go through the existing PurchaseHandler instance instead (the person working on the RC app will later thank us for this 😄).

RevenueCatUI/Templates/V2/Components/Button/ButtonComponentView.swift

ajpallares · 2025-07-31T16:12:50Z

RevenueCatUI/View+PresentPaywall.swift

+            await self.updateCustomerInfo()
+        }
+        .onChange(of: scenePhase) { newPhase in
+            // Used when Offer Code Redemption sheet dismisses


Good point from Toni here. The code currently only checks when the scenePhase passes to active. Perhaps we could restrict this to make it closer to the "when Offer Code Redemption sheet dismisses" event by using https://developer.apple.com/documentation/swiftui/view/onchange(of:initial:_:)-4psgg and only do updateCustomerInfo() if newPhase == .active && oldPhase == .inactive (this way we avoid calling it when coming from the .background)

emerge-tools · 2025-08-01T11:09:49Z

📸 Snapshot Test

1 modified, 704 unchanged

Name	Modified	Unchanged	Approval
RevenueCat com.revenuecat.PaywallsTester.mac-catalyst-scaled-to-match-ipad	0	235	N/A
RevenueCat com.revenuecat.PaywallsTester	0	235	N/A
RevenueCat com.revenuecat.PaywallsTester.mac-catalyst-optimized-for-mac	1	234	✅ Approved

🛸 Powered by Emerge Tools

ajpallares

Let's goo!
(just one small nit)

ajpallares · 2025-08-01T11:42:26Z

RevenueCatUI/Modifiers/ViewExtensions.swift

+                if old == new {
+                    action(.new(new))
+                } else {
+                    action(.changed(old: old, new: new))
+                }


Total nit, and I understand that it could be misleading to say changed when old == new, but that would be the fault of the system API calling onChange when the value didn't change. This way, we don't lose the oldValue information (and we wouldn't be getting the Customer Info below if both old and new were .active

Suggested change

if old == new {

action(.new(new))

} else {

action(.changed(old: old, new: new))

}

action(.changed(old: old, new: new))

Oh yeah, good point! Will change this 👍

ajpallares · 2025-08-01T11:47:24Z

RevenueCatUI/Templates/V2/Components/Button/ButtonComponentView.swift

        }
    }

+    private func openCodeREDemptionSheet() {
+        Purchases.shared.presentCodeRedemptionSheet()


As talked with Josh privately, removing the Purchases.shared here is more intricate than it looks. So it'll be tackled in a future PR (thank you Swift protocols for not allowing @Availability checks in your methods)

joshdholtz added pr:feat A new feature pr:RevenueCatUI feat:PaywallV2 labels Jul 30, 2025

joshdholtz requested review from a team July 31, 2025 11:02

Auto dismisses with Redeem Offer Code

1e0076d

tonidero reviewed Jul 31, 2025

View reviewed changes

ajpallares reviewed Jul 31, 2025

View reviewed changes

joshdholtz and others added 10 commits July 31, 2025 19:05

Removed use of Purchases.shared

a5910cb

Maybe this

e6020ad

Maybe this????

925bf48

Maybe this

2701a68

Maybe this

d1d9c82

Maybe this

8d8e414

Please compile

d962a57

This?????

7e2562a

Just anything

b19690c

try this

e222a58

ajpallares approved these changes Aug 1, 2025

View reviewed changes

joshdholtz added 3 commits August 1, 2025 06:55

Don't call new from change

d252c9a

Oops, forgot one more thing

99c8e22

Do it the right way

2577e22

joshdholtz merged commit 994bee3 into main Aug 1, 2025
12 checks passed

joshdholtz deleted the paywall-button-offer-code-redemption branch August 1, 2025 12:37

RCGitBot mentioned this pull request Aug 1, 2025

[AUTOMATIC] Release/5.34.0 #5447

Merged

Add offer code redemption support to paywall buttons #5437

Add offer code redemption support to paywall buttons #5437

Uh oh!

Conversation

joshdholtz commented Jul 30, 2025

Summary

Test plan

Uh oh!

tonidero left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ajpallares left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

emerge-tools bot commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📸 Snapshot Test

1 modified, 704 unchanged

Uh oh!

ajpallares left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

emerge-tools bot commented Aug 1, 2025 •

edited

Loading