Skip to content

Improve paywall tabs default state and toggle behavior #5430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 30, 2025
Merged

Improve paywall tabs default state and toggle behavior #5430

merged 4 commits into from
Jul 30, 2025

Conversation

joshdholtz
Copy link
Member

Summary

  • Enhances tab control components to better handle default tab selection and toggle state management
  • Improves tab switching logic and default state initialization across paywall templates
  • Updates toggle component behavior for more consistent user experience

Changes

  • TabControlToggleComponentView.swift: Updated toggle component UI and state handling
  • TabControlToggleComponentViewModel.swift: Enhanced view model logic for toggle state management
  • TabsComponentView.swift: Improved tab view rendering and selection behavior
  • TabsComponentViewModel.swift: Updated tab component view model with better default state handling
  • PaywallTabsComponent.swift: Enhanced core paywall tabs component functionality

Test Plan

  • Verify default tab selection works correctly on paywall load
  • Test tab switching functionality across different paywall templates
  • Confirm toggle state persists appropriately during user interactions
  • Validate behavior on different device orientations and screen sizes

🤖 Generated with Claude Code

@joshdholtz joshdholtz requested review from a team July 29, 2025 17:37
@joshdholtz @claude
Improve paywall tabs default state and toggle behavior
9d6fa48 
Updates tab control components to handle default tab selection and toggle state management more effectively. Changes include improvements to tab switching logic, default state initialization, and toggle component behavior across paywall templates.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@joshdholtz joshdholtz force-pushed the paywalls-default-tab-and-toggle-state branch from 72edc25 to 9d6fa48 Compare July 29, 2025 17:40
@emerge-tools Emerge Tools
Copy link

emerge-tools bot commented Jul 29, 2025 •
edited
Loading

📸 Snapshot Test

705 unchanged

Name Added Removed Modified Renamed Unchanged Errored Approval
RevenueCat
com.revenuecat.PaywallsTester.mac-catalyst-optimized-for-mac		 0 0 0 0 235 0 N/A
RevenueCat
com.revenuecat.PaywallsTester.mac-catalyst-scaled-to-match-ipad		 0 0 0 0 235 0 N/A
RevenueCat
com.revenuecat.PaywallsTester		 0 0 0 0 235 0 N/A

🛸 Powered by Emerge Tools

@joshdholtz joshdholtz merged commit d68ec4d into main Jul 30, 2025
12 checks passed
@joshdholtz joshdholtz deleted the paywalls-default-tab-and-toggle-state branch July 30, 2025 11:47
@RCGitBot RCGitBot mentioned this pull request Jul 30, 2025
Closed
@JayShortway JayShortway mentioned this pull request Jul 31, 2025
Open
@RCGitBot RCGitBot mentioned this pull request Aug 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkVillacampa MarkVillacampa MarkVillacampa approved these changes

@francocorreasosa francocorreasosa francocorreasosa approved these changes

Assignees
No one assigned
Labels
pr:fix A bug fix pr:RevenueCatUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshdholtz @MarkVillacampa @francocorreasosa