Skip to content

Rename internal WebProducts APIs to WebOfferingProducts #5416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2025
Merged

Rename internal WebProducts APIs to WebOfferingProducts #5416

merged 3 commits into from
Jul 23, 2025

Conversation

ajpallares
Copy link
Member

Description

This PR renames all the internal APIs, variables, methods and tests from WebProducts to WebOfferingProducts for the existing endpoint

"/rcbilling/v1/subscribers/\(user_id)/offering_products"

Motivation

In a future PR we'll add a new endpoint for fetching web products that better fits the WebProducts naming:

"rcbilling/v1/subscribers/\(user_id)/products?id=product_id"

I preferred to have this refactor in a separate PR so that the future PR that adds the new endpoint is clearer to review.

@ajpallares ajpallares requested a review from a team July 23, 2025 11:04
@emerge-tools Emerge Tools
Copy link

emerge-tools bot commented Jul 23, 2025 •
edited
Loading

📸 Snapshot Test

1 modified, 704 unchanged

Name Added Removed Modified Renamed Unchanged Errored Approval
RevenueCat
com.revenuecat.PaywallsTester		 0 0 0 0 235 0 N/A
RevenueCat
com.revenuecat.PaywallsTester.mac-catalyst-optimized-for-mac		 0 0 0 0 235 0 N/A
RevenueCat
com.revenuecat.PaywallsTester.mac-catalyst-scaled-to-match-ipad		 0 0 1 0 234 0 ✅ Approved

🛸 Powered by Emerge Tools

tonidero
tonidero approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! Thanks for doing this! Will certainly help to keep things organized :)

@ajpallares
Copy link
Member Author

@RCGitBot please test

@ajpallares ajpallares merged commit b7c98a0 into main Jul 23, 2025
41 checks passed
@ajpallares ajpallares deleted the rename-WebProducts-internal-APIs branch July 23, 2025 11:56
@RCGitBot RCGitBot mentioned this pull request Jul 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonidero tonidero tonidero approved these changes

Assignees
No one assigned
Labels
pr:other
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajpallares @tonidero