Fix issue where previews running on Emerge servers were not following specialized codepaths for previews #5413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… runtime path for Xcode previews.
📸 Snapshot Test2 modified, 703 unchanged
🛸 Powered by Emerge Tools |
ajpallares
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Certain screenshots in Emerge are flaky, and we suspect it might be because they are not using the codepaths setup explicitly for previews, to avoid doing things like network requests or accessing external resources.
Description
Adds a new extension on
ProcessInfocalledisRunningForPreviewsthat checks for bothXCODE_RUNNING_FOR_PREVIEWS == "1"(set when running previews in Xcode) andEMERGE_IS_RUNNING_FOR_SNAPSHOTS == "1"(set when running on Emerge's screenshot servers). Update all references toXCODE_RUNNING_FOR_PREVIEWSto this new shared ProcessInfo extension.