Skip to content

Tuist: fix some setup issues #5400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 21, 2025
Merged

Tuist: fix some setup issues #5400

merged 3 commits into from
Jul 21, 2025

Conversation

ajpallares
Copy link
Member

This PR fixes some issues we had with tuist-generated projects:

  • SWIFT_ACTIVE_COMPILATION_CONDITIONS from xcconfig files were not being propagated to framework targets (e.g. RevenueCat and RevenueCatUI)
  • SWIFT_ACTIVE_COMPILATION_CONDITIONS from xcconfig files were not being propagated to the visionOS platforms
  • Running apps in visionOS would not work due to the minimum deployment version for visionOS not being correctly set

@ajpallares ajpallares requested review from facumenzella and a team July 18, 2025 16:17
JayShortway
JayShortway approved these changes Jul 18, 2025
View reviewed changes
Copy link
Member

@JayShortway JayShortway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice job figuring this out! Just a suggestion to use Tuist's env vars instead. Not a blocker.

@emerge-tools Emerge Tools
Copy link

emerge-tools bot commented Jul 18, 2025 •
edited
Loading

📸 Snapshot Test

2 modified, 703 unchanged

Name Added Removed Modified Renamed Unchanged Errored Approval
RevenueCat
com.revenuecat.PaywallsTester.mac-catalyst-optimized-for-mac		 0 0 2 0 233 0 ✅ Approved
RevenueCat
com.revenuecat.PaywallsTester.mac-catalyst-scaled-to-match-ipad		 0 0 0 0 235 0 N/A
RevenueCat
com.revenuecat.PaywallsTester		 0 0 0 0 235 0 N/A

🛸 Powered by Emerge Tools

@ajpallares ajpallares merged commit 0c64729 into main Jul 21, 2025
12 checks passed
@ajpallares ajpallares deleted the tuist/fix-some-setup-issues branch July 21, 2025 07:13
@RCGitBot RCGitBot mentioned this pull request Jul 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JayShortway JayShortway JayShortway approved these changes

@facumenzella facumenzella Awaiting requested review from facumenzella

Assignees
No one assigned
Labels
pr:other
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajpallares @facumenzella @JayShortway