Skip to content

Conversation

fire-at-will
Copy link
Contributor

@fire-at-will fire-at-will commented Jul 11, 2025

This PR includes the following PRs with no other changes:

It is the collection of all of the work required to update the VC APIs and fetch the virtual currencies from the new v1 endpoint. To keep the PR sizes manageable, the work was broken up into smaller PRs, which have been individually approved and aggregated into this branch.

Forgoing a review on this PR since all changes have already been reviewed, and we'll do a final review when we merge virtual-currency-dev into main

@fire-at-will fire-at-will self-assigned this Jul 11, 2025
@fire-at-will fire-at-will added the pr:feat A new feature label Jul 11, 2025
@fire-at-will fire-at-will marked this pull request as ready for review July 11, 2025 15:23
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

Attention: Patch coverage is 85.00000% with 30 lines in your changes missing coverage. Please review.

Please upload report for BASE (virtual-currency-dev@ad9ce96). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...chases/virtualcurrencies/VirtualCurrencyManager.kt 88.13% 7 Missing ⚠️
...in/com/revenuecat/purchases/listenerConversions.kt 0.00% 6 Missing ⚠️
...n/com/revenuecat/purchases/coroutinesExtensions.kt 0.00% 5 Missing ⚠️
...revenuecat/purchases/common/caching/DeviceCache.kt 90.56% 3 Missing and 2 partials ⚠️
.../com/revenuecat/purchases/PurchasesOrchestrator.kt 25.00% 3 Missing ⚠️
.../kotlin/com/revenuecat/purchases/common/Backend.kt 97.67% 0 Missing and 1 partial ⚠️
...nuecat/purchases/strings/VirtualCurrencyStrings.kt 0.00% 1 Missing ⚠️
...t/purchases/virtualcurrencies/VirtualCurrencies.kt 75.00% 0 Missing and 1 partial ⚠️
...cat/purchases/virtualcurrencies/VirtualCurrency.kt 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##             virtual-currency-dev    #2518   +/-   ##
=======================================================
  Coverage                        ?   79.02%           
=======================================================
  Files                           ?      294           
  Lines                           ?    10691           
  Branches                        ?     1527           
=======================================================
  Hits                            ?     8449           
  Misses                          ?     1590           
  Partials                        ?      652           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fire-at-will fire-at-will merged commit 3c9a787 into virtual-currency-dev Jul 11, 2025
14 checks passed
@fire-at-will fire-at-will deleted the fetch-virtual-currencies-new-endpoint branch July 11, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:feat A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant