Use int for VC Balance #2332
Merged
Use int for VC Balance #2332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## virtual-currency-dev #2332 +/- ##
=======================================================
Coverage ? 80.37%
=======================================================
Files ? 282
Lines ? 9996
Branches ? 1421
=======================================================
Hits ? 8034
Misses ? 1347
Partials ? 615 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is the Android equivalent for RevenueCat/purchases-ios#4952. We recently decided to make the maximum balance for virtual currency balances be bounded by a signed 32-bit integer, so using a
Longhere inpurchases-androidis no longer necessary.Description
This PR changes the VirtualCurrencyInfo's
balancefield from aLongto anInt. Kotlin Ints are signed 32-bit integers (source), so this is fine. On the Java side of things, theintprimitive is also a signed 32-bit int (source), and the Integer class is also a 32-bit signed integer by transitivity since it wraps theintprimitive (source).This is technically a breaking change but that's okay since the Virtual Currency features are still in a beta state in the SDKs.