fix: refactor is-from-react utility and improve no-forward-ref rule autofix handling, closes #1172 #1173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…utofix handling, closes #1172
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the is-from-react utility and improves autofix handling for the no-forward-ref rule by making fixes conditional on whether the forwardRef call comes from React.
- Adds safety checks to prevent autofixing when
forwardRefis imported from non-React sources - Refactors the
is-from-reactutility by moving it to a more appropriate location and making it reusable - Updates package dependencies to newer versions
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/plugins/eslint-plugin-react-x/src/rules/no-forward-ref.ts | Adds canFix function to conditionally apply fixes only when forwardRef is from React |
| packages/plugins/eslint-plugin-react-x/src/rules/no-forward-ref.spec.ts | Adds test case for non-React import source to verify fix is not applied |
| packages/plugins/eslint-plugin-react-debug/src/rules/is-from-react.ts | Refactors by extracting isFromReact function to be reusable |
| packages/core/src/utils/is-from-react.ts | Updates JSDoc comments and adds @internal annotation |
| packages/core/src/utils/index.ts | Updates export to use new is-from-react module name |
| package.json & example packages | Updates various dependencies to newer versions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…ard-ref.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: REL1CX <dokimondex@gmail.com>
This was referenced Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information