Skip to content

fix #374 #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2017
Merged

fix #374 #375

merged 1 commit into from
Apr 26, 2017

Conversation

maiermic
Copy link
Contributor

See #374

@msftclas
Copy link

@maiermic,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@kirkshoop
Copy link
Member

clever. Thanks!

If you would like to improve this, it would be nice to have the commit message as a comment in the code and a test that would fail without this change.

@kirkshoop kirkshoop merged commit 18e8de2 into ReactiveX:master Apr 26, 2017
@maiermic
Copy link
Contributor Author

All right, I will improve it when I'm less busy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-already-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maiermic @msftclas @kirkshoop