Skip to content

Kirkshoop/filterimprovement #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2017

Conversation

kirkshoop
Copy link
Member

proposed changes to #364

@elelel, does this look okay?

whitespace changes are due to enforcement of the .editorconfig

@ghost ghost added the cla-not-required label Apr 7, 2017
@elelel
Copy link
Contributor

elelel commented Apr 7, 2017

Sure, I'm not informed enough to make suggestions here :)

Are we safe from the user calling on_next with a const rvalue directly?

@kirkshoop kirkshoop force-pushed the kirkshoop/filterimprovement branch from b6bd14e to b274a85 Compare April 9, 2017 00:43
@kirkshoop
Copy link
Member Author

Thanks!

Yes, one of the weird parts of perfect-forwarding in C++ is that since the Value&& v parameter is named, it is not an R-Value which is why std::forward must be used to recover the original type.

This means that this use of as_const in on_next will not ever be passed an R-Value.

@kirkshoop kirkshoop force-pushed the kirkshoop/filterimprovement branch from b274a85 to d6edcab Compare April 10, 2017 20:06
@kirkshoop
Copy link
Member Author

@elel, thank you for the help in getting this done.

@kirkshoop kirkshoop merged commit 201dd99 into ReactiveX:master Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants