Skip to content

Fix firstValueAfterNil not starting effects when initial state gives non-nil transformed value #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2020
Merged

Fix firstValueAfterNil not starting effects when initial state gives non-nil transformed value #22

merged 1 commit into from
Aug 18, 2020

Conversation

andersio
Copy link
Member

Fix the effect not being started in either of these two scenarios:

  1. Given the firstValueAfterNil transform, the initial state gives a non-nil transformed value.
  2. Given the whenBecomesTrue predicate, the initial state satisfies the predicate.

@andersio andersio added the bug Something isn't working label Aug 18, 2020
@andersio andersio self-assigned this Aug 18, 2020
@andersio andersio merged commit 525ee38 into develop Aug 18, 2020
@andersio andersio deleted the anders/patch branch August 18, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RuiAAPeres RuiAAPeres RuiAAPeres approved these changes

@sergdort sergdort sergdort approved these changes

Assignees

@andersio andersio

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andersio @RuiAAPeres @sergdort