-
Notifications
You must be signed in to change notification settings - Fork 48
apt: remove not allowed dist-upgrade #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
281e0d0
to
ac6f302
Compare
while this is "best practice", I'm not sure we actually should stop updating the base image. "ubuntu:bionic" is still at its initial version, right? |
We should not update an underling layer, because it simply costs resources in build time and storage. The base image should be always up to date. |
Should I add the Line 10 in 2ac1e6c
? |
Do you have a reference for this? Docker Hub using old versions of the parent image might be the reason that every dist-upgrade actually upgrades a lot. |
You mean? Ubuntu image:
|
Yes, thanks! I also found this: https://anchore.com/look-often-docker-images-updated/ |
Yes please! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK.
Base image should be up to date.
"Avoid RUN apt-get upgrade and dist-upgrade, as many of the “essential” packages from the parent images cannot upgrade inside an unprivileged container. "
Reference:
https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#run