Update to Ubuntu 2020.04 LTS #104

kaspar030 · 2020-05-05T11:00:27Z

This PR updates the base for our build container to Ubuntu focal (2020.04).

There's no coccinelle package anymore for focal in the coccinelle ppa, so I've added a binary package.
Same with libsocketcan.

In order to not clutter the git history with binary data, those package files have been added using git lfs, and the build.yml workflow has been adapted to pull the lfs files.

~~WIP, want to see travis output~~

kaspar030 · 2020-05-07T13:36:11Z

2020.04 doesn't include coccinelle. This PR adds a self-compiled version, need to test that. And, maybe not include it in the repo, it is like 5mb.

What do you guys think?

aabadie · 2020-05-19T15:51:57Z

Ubuntu 20.04 also includes a version of doxygen that generates tons of warning. This will break the static tests.

kaspar030 · 2020-05-20T07:51:41Z

Ubuntu 20.04 also includes a version of doxygen that generates tons of warning. This will break the static tests.

oh yes, I got the same on arch. That's a bummer.

miri64 · 2020-07-01T09:34:40Z

This PR should also be tested for RIOT-OS/RIOT#14288.

miri64 · 2020-07-01T09:35:19Z

Ubuntu 20.04 also includes a version of doxygen that generates tons of warning. This will break the static tests.

oh yes, I got the same on arch. That's a bummer.

I guess its time to find out how to deactivate those in config ;-).

MrKevinWeiss · 2020-08-18T09:50:09Z

Do you need to add apt install linux-libc-dev:i386 as well so native can compile?

kaspar030 · 2020-10-02T11:11:25Z

Do you need to add apt install linux-libc-dev:i386 as well so native can compile?

not sure it get's selected somehow, but travis did compile native correctly.

kaspar030 · 2020-10-20T13:40:07Z

rebased. let's see if the static tests fail now (they should show a lot of new documentation warnings)

kaspar030 · 2020-10-20T14:44:37Z

* they should show a lot of new documentation warnings

Hm, it didn't. :/

miri64 · 2021-01-07T17:53:09Z

Ubuntu 20.04 also includes a version of doxygen that generates tons of warning. This will break the static tests.

As those checks are run through a parsing script anyways, we could add exclude patterns for the warnings we deem false negatives.

miri64 · 2021-01-13T16:16:13Z

Many of those false positives should have been fixed in doxygen 1.8.16 btw... not sure, why they still show up. Will investigate.

See-Also: RIOT-OS#16025 (review) Workaround-For: RIOT-OS/riotdocker#104

benpicco · 2021-04-12T14:22:05Z

Dockerfile

@@ -29,6 +29,13 @@ ENV DEBIAN_FRONTEND noninteractive
 ENV LC_ALL C.UTF-8
 ENV LANG C.UTF-8

+# copy some included packages
+RUN mkdir /pkgs
+COPY files/coccinelle_1.0.8~19.04npalix1_amd64.deb /pkgs/coccinelle_1.0.8~19.04npalix1_amd64.deb


Why not use https://packages.ubuntu.com/bionic/coccinelle ?

ah nvm, this particular version only appeared in groovy

benpicco · 2021-04-12T14:22:37Z

Dockerfile

+# copy some included packages
+RUN mkdir /pkgs
+COPY files/coccinelle_1.0.8~19.04npalix1_amd64.deb /pkgs/coccinelle_1.0.8~19.04npalix1_amd64.deb
+COPY files/libsocketcan-dev_0.0.11-1_i386.deb /pkgs/libsocketcan-dev_0.0.11-1_i386.deb


and https://packages.ubuntu.com/bionic/libsocketcan-dev

ah nvm, this particular version only appeared in groovy

larseggert · 2021-08-23T08:52:17Z

Any ETA on merging this? I'm trying to port a package to RIOT that requires a pretty modern cmake.

kaspar030 · 2021-08-23T09:58:05Z

This is mostly blocked by the newer Doxygen, which warns on a lot more undocumented stuff than the bionic one.
Fixing all of those is a bigger task. We could work around by using the older version for this container.
Anyhow, there's no ETA and AFAIK, noone working on this.

miri64 · 2021-08-24T16:08:19Z

This is mostly blocked by the newer Doxygen, which warns on a lot more undocumented stuff than the bionic one.

Is there really no one willing to look into how to surppress or fix those doxygen warnings? Looking at the doxygen output in Arch I don't see this solving by itself. We are now closer to the next LTS than we are to 2020.04, so only ~1,5 years time to solve this before 2018.04 will reach EOL. IMHO someone(TM) should fix this ASAP. It's a boring job and shooting at a moving target, granted, but it should be done.

kaspar030 · 2021-08-25T20:08:31Z

It might be more fruitful to integrate the older doxygen version in this PR, no need to block on a specific tool version.

kaspar030 · 2021-10-29T06:39:11Z

Doxygen warnings are down to this:

ERROR: Doxygen generates the following warnings:
	boards/nucleo-g070rb/include/periph_conf.h:139: warning: end of file with unbalanced grouping commands
	boards/nucleo-g071rb/include/periph_conf.h:137: warning: end of file with unbalanced grouping commands
	boards/nucleo-g070rb/include/periph_conf.h:108: warning: Member ADC_NUMOF (macro definition) of file periph_conf.h is not documented.
	boards/nucleo-g070rb/include/periph_conf.h:99: warning: Member adc_config[] (variable) of file periph_conf.h is not documented.
	boards/nucleo-g071rb/include/periph_conf.h:106: warning: Member ADC_NUMOF (macro definition) of file periph_conf.h is not documented.
	boards/nucleo-g071rb/include/periph_conf.h:97: warning: Member adc_config[] (variable) of file periph_conf.h is not documented.

I guess I could add these to master?

kaspar030 · 2021-10-29T06:42:31Z

I guess I could add these to master?

oh, and either those would have to be commited to 2021.10-branch, or we'd need to change the RIOT base branch of this repo's workflow.

kaspar030 · 2021-10-29T07:09:58Z

From experience: that is not really hard. Just install git lfs install and git lfs <filename> and add both <filename> and .gitattributes to the repo.

Yeah, that's how it looks. I think adapting the workflows might involve a bit more. (I looked it up, there's an "lfs: true" flag for the checkout action, but another "git lfs pull" might be needed.)

Is anyone against this for any reason? otherwise I'd give it a shot.

that was really painless. I added *.deb though, instead of the individual files.

kaspar030 · 2021-10-29T18:08:26Z

bors try

bors · 2021-10-29T18:30:56Z

try

Build succeeded:

Build and Test

kaspar030 · 2021-10-29T18:50:36Z

doccheck succeeded now.

In some of my experiments on my 20.04 machine I noticed some problems with tinydtls that I do not have on my Arch machine (some numbers are wrong on the receiving end). Maybe we should check that as well before merging.

do you remember any details?

kaspar030 · 2021-10-29T18:56:57Z

do you remember any details?

we're early in the release cycle, so I'd suggest now that the doxygen issue is solved, we go with this as is. for tinydtls, we can open an issue so we don't forget verifying that still works. (it should, the toolchain used is the same).

fjmolinas · 2021-11-02T08:44:10Z

Please squash

miri64 · 2021-11-02T08:52:03Z

I lately noticed some weird behavior of gCoAP over TinyDTLS when compiled my Ubuntu 20.04 machine (the python-based server receives TinyDTLS packets from the gCoAP client that it can not decypher, due to an "unknown TLS extension 23"). Not a blocker, but we should keep an eye of this during the coming release cycle.

miri64 · 2021-11-02T08:55:55Z

bors try

fjmolinas

ACK

fjmolinas · 2021-11-02T09:09:19Z

bors merge

bors · 2021-11-02T09:15:42Z

try

Build succeeded:

Build and Test

bors · 2021-11-02T09:32:49Z

Build succeeded:

Build and Test

larseggert · 2021-11-02T10:31:47Z

Thank you for getting this merged!

153: Build C2Rust on focal r=kaspar030 a=chrysn This issue tracks changes needed in the Rust installation (OK: C2Rust -- the rest should just work) when #104 is rebased and gets merged. By building c2rust on the same Ubuntu release (focal), the friction between different installed LLVM versions will be reduced. This * switches from using c2rust's shipped build containers (which made sense back when supported Ubuntus had those old LLVM versions) to a plain feisty base, * consequently installs the build-deps manually, and * builds a Debian binary package in the course of installing c2rust. The latter is done to get us rid of the manual `apt-get install llvm-7-dev` (and pray that it matches what c2rust needs) in favor of copying the .deb out of the c2rust image and getting the right build-deps automatically. (A part of building a Debian package is the tools inspecting any binaries for used shared libraries, looking up the packages they're in, and looking at that library's exported symbol versionings to get a correctly version for the dependency). <del>Put on hold / WIP / draft until #104 is done, given that these don't need lockstepping yet.</del> Co-authored-by: chrysn <chrysn@fsfe.org>

This was referenced May 7, 2020

dist/tools/uncrustify: temporarily disable error on check failure RIOT-OS/RIOT#14040

Merged

bump travis RIOT version to 2020.04-branch #105

Merged

kaspar030 force-pushed the update_to_focal branch from c18a6ab to c89927b Compare May 7, 2020 13:05

kaspar030 force-pushed the update_to_focal branch from c89927b to a6193a7 Compare May 7, 2020 13:39

miri64 mentioned this pull request Jul 1, 2020

pkg/ccn-lite: unable to make -j -C examples/ccn-lite-relay RIOT-OS/RIOT#14288

Closed

miri64 mentioned this pull request Jul 7, 2020

Provided pexpect version does not work with python>3.7 #110

Closed

kaspar030 changed the title ~~Update to Ubuntu 2020.04 LTS~~ Update to Ubuntu 2020.04 LTS (don't merge yet!) Aug 11, 2020

benpicco mentioned this pull request Oct 2, 2020

Dockerfile: install picolibc & ARM/RISC-V GCC via package manager #116

Merged

kaspar030 force-pushed the update_to_focal branch from a6193a7 to 0d1ea7b Compare October 20, 2020 13:37

chrysn mentioned this pull request Feb 17, 2021

doc: Make bootloaders visible in modules RIOT-OS/RIOT#16025

Merged

chrysn added a commit to chrysn-pull-requests/RIOT that referenced this pull request Feb 17, 2021

doc: Workarounds for Doxygen 1.8

a1e4b41

See-Also: RIOT-OS#16025 (review) Workaround-For: RIOT-OS/riotdocker#104

chrysn added a commit to chrysn-pull-requests/RIOT that referenced this pull request Feb 18, 2021

doc: Workaround for Doxygen 1.8

9304467

See-Also: RIOT-OS#16025 (review) Workaround-For: RIOT-OS/riotdocker#104

chrysn added a commit to chrysn-pull-requests/RIOT that referenced this pull request Feb 18, 2021

doc: Workaround for Doxygen 1.8

010dbcc

See-Also: RIOT-OS#16025 (review) Workaround-For: RIOT-OS/riotdocker#104

benpicco reviewed Apr 12, 2021

View reviewed changes

larseggert mentioned this pull request Aug 4, 2021

ubuntu:focal #151

Closed

This was referenced Oct 29, 2021

boards/nucleo-g07xrb: fix or exclude some doxygen warnings RIOT-OS/RIOT#17079

Merged

boards/nucleo-g07xrb: fix or exclude some doxygen warnings [backport 2021.10] RIOT-OS/RIOT#17084

Merged

bors bot added a commit that referenced this pull request Oct 29, 2021

Try #104:

cec1f4c

kaspar030 changed the title ~~Update to Ubuntu 2020.04 LTS (don't merge yet!)~~ Update to Ubuntu 2020.04 LTS Oct 29, 2021

kaspar030 added 6 commits November 2, 2021 09:44

update to Ubuntu 2020.04 LTS

9e8fa3a

riotbuild: drop "/bionic-updates" for llvm packages

2a9cd20

static-test-tools: add coccinelle package

66a1822

riotbuild: add libsocketcan package files

e5d2d2d

.gitattributes: initial commit, lfs for *.deb

b7d3caf

.github/workflows/build.yml: add lfs: true to version tag

7ce5232

kaspar030 force-pushed the update_to_focal branch from b69be41 to 7ce5232 Compare November 2, 2021 08:45

bors bot added a commit that referenced this pull request Nov 2, 2021

Try #104:

16176eb

fjmolinas approved these changes Nov 2, 2021

View reviewed changes

bors bot merged commit 6fdc262 into RIOT-OS:master Nov 2, 2021

kaspar030 deleted the update_to_focal branch November 2, 2021 09:38

Update to Ubuntu 2020.04 LTS #104

Update to Ubuntu 2020.04 LTS #104

Uh oh!

Conversation

kaspar030 commented May 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kaspar030 commented May 7, 2020

Uh oh!

aabadie commented May 19, 2020

Uh oh!

kaspar030 commented May 20, 2020

Uh oh!

miri64 commented Jul 1, 2020

Uh oh!

miri64 commented Jul 1, 2020

Uh oh!

MrKevinWeiss commented Aug 18, 2020

Uh oh!

kaspar030 commented Oct 2, 2020

Uh oh!

kaspar030 commented Oct 20, 2020

Uh oh!

kaspar030 commented Oct 20, 2020

Uh oh!

miri64 commented Jan 7, 2021

Uh oh!

miri64 commented Jan 13, 2021

Uh oh!

benpicco Apr 12, 2021

Choose a reason for hiding this comment

Uh oh!

benpicco Apr 12, 2021

Choose a reason for hiding this comment

Uh oh!

benpicco Apr 12, 2021

Choose a reason for hiding this comment

Uh oh!

benpicco Apr 12, 2021

Choose a reason for hiding this comment

Uh oh!

larseggert commented Aug 23, 2021

Uh oh!

kaspar030 commented Aug 23, 2021

Uh oh!

miri64 commented Aug 24, 2021

Uh oh!

kaspar030 commented Aug 25, 2021

Uh oh!

kaspar030 commented Oct 29, 2021

Uh oh!

kaspar030 commented Oct 29, 2021

Uh oh!

kaspar030 commented Oct 29, 2021

Uh oh!

kaspar030 commented Oct 29, 2021

Uh oh!

bors bot commented Oct 29, 2021

try

Uh oh!

kaspar030 commented Oct 29, 2021

Uh oh!

kaspar030 commented Oct 29, 2021

Uh oh!

fjmolinas commented Nov 2, 2021

Uh oh!

miri64 commented Nov 2, 2021

Uh oh!

miri64 commented Nov 2, 2021

Uh oh!

fjmolinas left a comment

Choose a reason for hiding this comment

Uh oh!

fjmolinas commented Nov 2, 2021

Uh oh!

bors bot commented Nov 2, 2021

try

Uh oh!

bors bot commented Nov 2, 2021

Uh oh!

kaspar030 commented May 5, 2020 •

edited

Loading