Skip to content

Conversation

fjmolinas
Copy link
Contributor

This PR removes travis-ci and docker-hub hooks, bors should now check the the github action build result when pushing to trying and staging...

Testing procedure:

  • run bors try and it should look at the github action result.

@fjmolinas
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Jun 7, 2021
@fjmolinas
Copy link
Contributor Author

Looks like the status checks is wrong..

bors.toml Outdated
@@ -1 +1 @@
status = ["continuous-integration/travis-ci/push"]
status = ["build"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this must be build / Build and Test (push).

I don't know where to find this easily. I clicked on the "code" tab of the repo, changed the branch to trying. There is a green check sign next to the commit. If I click that, I see "build / Build ..." abbrevated. I used firefox' "Inspect element" to see the full text...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you try this?

@fjmolinas
Copy link
Contributor Author

bors cancel

@fjmolinas
Copy link
Contributor Author

bors try

@bors
Copy link
Contributor

bors bot commented Jun 7, 2021

try

Already running a review

@bors
Copy link
Contributor

bors bot commented Jun 7, 2021

try

Timed out.

@kaspar030
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request Jun 7, 2021
@fjmolinas
Copy link
Contributor Author

Seems that it didn't work either, trying with your suggestion

bors.toml Outdated
@@ -1 +1 @@
status = ["continuous-integration/travis-ci/push"]
status = ["build / Build and Test (push)"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just guessing, but maybe just

Suggested change
status = ["build / Build and Test (push)"]
status = ["build / Build and Test"]

The thing in parens is just the trigger (see in the PR checks where it is (pull request).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If https://www.christopherbiscardi.com/integrating-bors-with-github-actions is to believe, I think it should be

Suggested change
status = ["build / Build and Test (push)"]
status = ["Build and Test"]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets see

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this back to before or is github's ui tricking me?

@bors
Copy link
Contributor

bors bot commented Jun 7, 2021

try

Timed out.

@kaspar030
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request Jun 7, 2021
@miri64
Copy link
Member

miri64 commented Jun 7, 2021

bors try

@bors
Copy link
Contributor

bors bot commented Jun 7, 2021

try

Already running a review

@miri64
Copy link
Member

miri64 commented Jun 7, 2021

bors help

@miri64
Copy link
Member

miri64 commented Jun 7, 2021

Can one tell boars to stop trying? The action already succeeeded.

@fjmolinas
Copy link
Contributor Author

Can one tell boars to stop trying? The action already succeeeded.

I tried with bors cancel but it doesn't seem to work...

@kaspar030
Copy link
Contributor

bors cancel

@kaspar030
Copy link
Contributor

bors ping

@bors
Copy link
Contributor

bors bot commented Jun 7, 2021

pong

@kaspar030
Copy link
Contributor

bors help

@kaspar030
Copy link
Contributor

bors try-

@kaspar030
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request Jun 7, 2021
@miri64
Copy link
Member

miri64 commented Jun 7, 2021

bors try-

Was that what did the trick?

@kaspar030
Copy link
Contributor

kaspar030 commented Jun 7, 2021

yup, "bors cancel" cancels a merge request, "bors try-" the trying... https://bors.tech/documentation/ -> "Reference"

@fjmolinas
Copy link
Contributor Author

yup, "bors cancel" cancels a merge request, "bors try-" the trying... https://bors.tech/documentation/ -> "Reference"

Who would have though we only needed to read the doc hahahah

@kaspar030
Copy link
Contributor

Who would have though we only needed to read the doc hahahah

well you'd expect a UI to work intuitively for smart people like us. 😎

@bors
Copy link
Contributor

bors bot commented Jun 7, 2021

try

Build succeeded:

@fjmolinas
Copy link
Contributor Author

try

Build succeeded:

* [Build and Test](https://github.com/RIOT-OS/riotdocker/runs/2763682909)

Should I squash?

@kaspar030
Copy link
Contributor

yes please!

@fjmolinas fjmolinas force-pushed the pr_ci_switch_to_ga branch from eb188de to f6a8e0d Compare June 7, 2021 12:26
@miri64
Copy link
Member

miri64 commented Jun 7, 2021

yup, "bors cancel" cancels a merge request, "bors try-" the trying... https://bors.tech/documentation/ -> "Reference"

Maybe it's just me, but I was searching for such a cheat sheet and could not find it... maybe need to reevaluate my googling skills ^^"

Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@kaspar030
Copy link
Contributor

bors cancel

@bors
Copy link
Contributor

bors bot commented Jun 7, 2021

Canceled.

@fjmolinas
Copy link
Contributor Author

Wait I forgot to pull the changes.

@kaspar030
Copy link
Contributor

rebase mishap I think

@fjmolinas fjmolinas force-pushed the pr_ci_switch_to_ga branch from f6a8e0d to 833fbf3 Compare June 7, 2021 12:29
@kaspar030
Copy link
Contributor

Now please @miri64 :)

Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@miri64
Copy link
Member

miri64 commented Jun 7, 2021

(testing btw if it also catches review comments ;-))

@kaspar030
Copy link
Contributor

(testing btw if it also catches review comments ;-))

seems so!

Next thing would be to configure bors to require rewiews.

@miri64
Copy link
Member

miri64 commented Jun 7, 2021

(testing btw if it also catches review comments ;-))

seems so!

Next thing would be to configure bors to require rewiews.

unlimited power GIF

@miri64
Copy link
Member

miri64 commented Jun 7, 2021

(testing btw if it also catches review comments ;-))

seems so!
Next thing would be to configure bors to require rewiews.

unlimited power GIF

:-/ remember the time when gifs were easy 🙄 ...

@bors
Copy link
Contributor

bors bot commented Jun 7, 2021

Build succeeded:

@bors bors bot merged commit 9e26c74 into RIOT-OS:master Jun 7, 2021
@fjmolinas fjmolinas deleted the pr_ci_switch_to_ga branch June 7, 2021 12:53
@chrysn chrysn mentioned this pull request Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants