-
Notifications
You must be signed in to change notification settings - Fork 48
ci: switch to github actions #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bors try |
Looks like the status checks is wrong.. |
bors.toml
Outdated
@@ -1 +1 @@ | |||
status = ["continuous-integration/travis-ci/push"] | |||
status = ["build"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this must be build / Build and Test (push)
.
I don't know where to find this easily. I clicked on the "code" tab of the repo, changed the branch to trying. There is a green check sign next to the commit. If I click that, I see "build / Build ..." abbrevated. I used firefox' "Inspect element" to see the full text...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you try this?
bors cancel |
bors try |
tryAlready running a review |
tryTimed out. |
bors try |
Seems that it didn't work either, trying with your suggestion |
bors.toml
Outdated
@@ -1 +1 @@ | |||
status = ["continuous-integration/travis-ci/push"] | |||
status = ["build / Build and Test (push)"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just guessing, but maybe just
status = ["build / Build and Test (push)"] | |
status = ["build / Build and Test"] |
The thing in parens is just the trigger (see in the PR checks where it is (pull request)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If https://www.christopherbiscardi.com/integrating-bors-with-github-actions is to believe, I think it should be
status = ["build / Build and Test (push)"] | |
status = ["Build and Test"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets see
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this back to before or is github's ui tricking me?
tryTimed out. |
bors try |
bors try |
tryAlready running a review |
bors help |
Can one tell boars to stop trying? The action already succeeeded. |
I tried with |
bors cancel |
bors ping |
pong |
bors help |
bors try- |
bors try |
Was that what did the trick? |
yup, "bors cancel" cancels a merge request, "bors try-" the trying... https://bors.tech/documentation/ -> "Reference" |
Who would have though we only needed to read the doc hahahah |
well you'd expect a UI to work intuitively for smart people like us. 😎 |
tryBuild succeeded: |
Should I squash? |
yes please! |
eb188de
to
f6a8e0d
Compare
Maybe it's just me, but I was searching for such a cheat sheet and could not find it... maybe need to reevaluate my googling skills ^^" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
bors cancel |
Canceled. |
Wait I forgot to pull the changes. |
rebase mishap I think |
f6a8e0d
to
833fbf3
Compare
Now please @miri64 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
(testing btw if it also catches review comments ;-)) |
seems so! Next thing would be to configure bors to require rewiews. |
Build succeeded: |
This PR removes travis-ci and docker-hub hooks, bors should now check the the github action build result when pushing to
trying
andstaging
...Testing procedure:
bors try
and it should look at the github action result.