drivers/isl29125: apply unified params definition scheme and new i2c API #9392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 tasks
|
This looks good. I'm supposed to receive custom board with this sensor very soon so I'll give it a try asap unless someone is faster than me. |
MrKevinWeiss
requested changes
Jun 27, 2018
| * @{ | ||
| */ | ||
| #ifndef ISL29125_PARAM_I2C | ||
| #define ISL29125_PARAM_I2C I2C_DEV(0) |
There was a problem hiding this comment.
Probably should == TEST_ISL29125_I2C
There was a problem hiding this comment.
I removed the parameters from the tests Makefile so there is only the one definition in this file, which can still be overwritten.
| #define ISL29125_PARAM_I2C I2C_DEV(0) | ||
| #endif | ||
| #ifndef ISL29125_PARAM_GPIO | ||
| #define ISL29125_PARAM_GPIO (GPIO_PIN(0, 0)) |
There was a problem hiding this comment.
Same here TEST_ISL29125_IRQ_PIN
There was a problem hiding this comment.
addressed: same as above
1d2f817 to
cd2bcf1
Compare
|
ACK, seems good to me and appears to work! |
MrKevinWeiss
approved these changes
Jun 27, 2018
basilfx
pushed a commit
to basilfx/RIOT
that referenced
this pull request
Jul 10, 2018
…ew_i2c drivers/isl29125: apply unified params definition scheme and new i2c API
dylad
pushed a commit
to dylad/RIOT
that referenced
this pull request
Jul 10, 2018
…ew_i2c drivers/isl29125: apply unified params definition scheme and new i2c API
dylad
pushed a commit
that referenced
this pull request
Jul 11, 2018
drivers/isl29125: apply unified params definition scheme and new i2c API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Analog to #8688 this updates the parameter scheme (#7519) and applies the new i2c API to the isl29125 driver.
tested with sparkfun isl29125 with nucleo-l073
Issues/PRs references
#6577