Skip to content

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Jun 8, 2018

Contribution description

This PR adapts the SI114x driver to the new I2C api (not tested yet).

Issues/PRs references

#6577

@aabadie aabadie added Area: drivers Area: Device drivers TF: I2C Marks issues and PRs related to the work of the I²C rework task force labels Jun 8, 2018
Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested ACK, but this just remove i2c_init_master and adds missing flag parameter to any i2c call. Code looks good

@aabadie aabadie merged commit 6d35d50 into RIOT-OS:new_i2c_if Jul 4, 2018
basilfx pushed a commit to basilfx/RIOT that referenced this pull request Jul 10, 2018
drivers/si114x: adapt to new i2c api
dylad pushed a commit to dylad/RIOT that referenced this pull request Jul 10, 2018
drivers/si114x: adapt to new i2c api
dylad pushed a commit that referenced this pull request Jul 11, 2018
drivers/si114x: adapt to new i2c api
@aabadie aabadie deleted the new_i2c_si114x branch August 31, 2018 07:05
@aabadie aabadie added this to the Release 2018.10 milestone Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: drivers Area: Device drivers TF: I2C Marks issues and PRs related to the work of the I²C rework task force
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants