Skip to content

drivers/mpu9150: adapt to new I2C api #9277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2018
Merged

drivers/mpu9150: adapt to new I2C api #9277

merged 1 commit into from
Jul 1, 2018

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Jun 2, 2018

Contribution description

Adapt mpu9150 driver to new I2C api

Issues/PRs references

#6577

@aabadie aabadie added Area: drivers Area: Device drivers TF: I2C Marks issues and PRs related to the work of the I²C rework task force labels Jun 2, 2018
@haukepetersen haukepetersen mentioned this pull request Jun 2, 2018
Closed
47 tasks
@aabadie aabadie force-pushed the new_i2c_if_mpu9150 branch from 199e5e1 to 4496b65 Compare June 7, 2018 21:49
@aabadie aabadie force-pushed the new_i2c_if_mpu9150 branch from 4496b65 to 8364976 Compare June 18, 2018 11:29
smlng
smlng suggested changes Jun 29, 2018
View reviewed changes
Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks good, tested on pba-d-01-kw2x with drivers test app.

drivers/mpu9150/mpu9150.c
@@ -515,51 +509,51 @@ static int compass_init(mpu9150_t *dev)
}

/* Configure Power Down mode */
i2c_write_reg(DEV_I2C, DEV_COMP_ADDR, COMPASS_CNTL_REG, MPU9150_COMP_POWER_DOWN);
i2c_write_reg(DEV_I2C, DEV_COMP_ADDR, COMPASS_CNTL_REG, MPU9150_COMP_POWER_DOWN, 0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you miss the i2c_read_reg call 7 lines above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, fixed!

@aabadie aabadie force-pushed the new_i2c_if_mpu9150 branch from 8364976 to e38d743 Compare June 29, 2018 14:07
@aabadie aabadie merged commit 84abd6f into RIOT-OS:new_i2c_if Jul 1, 2018
basilfx pushed a commit to basilfx/RIOT that referenced this pull request Jul 10, 2018
@aabadie @basilfx
Merge pull request RIOT-OS#9277 from aabadie/new_i2c_if_mpu9150
5459565 
drivers/mpu9150: adapt to new I2C api
dylad pushed a commit to dylad/RIOT that referenced this pull request Jul 10, 2018
@aabadie @dylad
Merge pull request RIOT-OS#9277 from aabadie/new_i2c_if_mpu9150
84262c6 
drivers/mpu9150: adapt to new I2C api
dylad pushed a commit that referenced this pull request Jul 11, 2018
@aabadie @dylad
Merge pull request #9277 from aabadie/new_i2c_if_mpu9150
8b50b3e 
drivers/mpu9150: adapt to new I2C api
@aabadie aabadie deleted the new_i2c_if_mpu9150 branch August 31, 2018 07:05
@aabadie aabadie added this to the Release 2018.10 milestone Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@smlng smlng smlng approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Area: drivers Area: Device drivers TF: I2C Marks issues and PRs related to the work of the I²C rework task force
Projects
None yet
Milestone
Release 2018.10
Development

Successfully merging this pull request may close these issues.
2 participants
@aabadie @smlng