drivers/hih6130: adapt to new i2c API #9270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 tasks
smlng
suggested changes
Jul 3, 2018
drivers/hih6130/hih6130.c
Outdated
| @@ -84,7 +84,7 @@ static inline int hih6130_get_humidity_temperature_raw(const hih6130_t *dev, uin | |||
|
|
|||
| i2c_acquire(dev->i2c); | |||
|
|
|||
| if (i2c_read_bytes(dev->i2c, dev->addr, &buf[0], sizeof(buf)) != sizeof(buf)) { | |||
| if (i2c_read_bytes(dev->i2c, dev->addr, &buf[0], sizeof(buf), 0) != sizeof(buf)) { | |||
There was a problem hiding this comment.
should != 0, does not return read bytes anymore
|
@smlng are you happy here ? |
smlng
reviewed
Jul 4, 2018
drivers/hih6130/hih6130.c
Outdated
| @@ -84,7 +84,7 @@ static inline int hih6130_get_humidity_temperature_raw(const hih6130_t *dev, uin | |||
|
|
|||
| i2c_acquire(dev->i2c); | |||
|
|
|||
| if (i2c_read_bytes(dev->i2c, dev->addr, &buf[0], sizeof(buf)) != sizeof(buf)) { | |||
| if (i2c_read_bytes(dev->i2c, dev->addr, &buf[0], sizeof(buf), 0) < 0{ | |||
There was a problem hiding this comment.
now its missing closing parentheses
There was a problem hiding this comment.
Ah crap, I edited on my phone through the web interface
|
@smlng can we squash and go ? |
smlng
approved these changes
Jul 5, 2018
|
sure, please squash |
|
@gebart ping, please squash |
|
All green, let's go! |
basilfx
pushed a commit
to basilfx/RIOT
that referenced
this pull request
Jul 10, 2018
drivers/hih6130: adapt to new i2c API
dylad
pushed a commit
to dylad/RIOT
that referenced
this pull request
Jul 10, 2018
drivers/hih6130: adapt to new i2c API
dylad
pushed a commit
that referenced
this pull request
Jul 11, 2018
drivers/hih6130: adapt to new i2c API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Adapt drivers/hih6130 to new i2c API
Issues/PRs references
#6577