Skip to content

drivers/at30tse75x: adapt to new I2C api #9229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2018
Merged

drivers/at30tse75x: adapt to new I2C api #9229

merged 2 commits into from
Jul 4, 2018

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented May 29, 2018

Contribution description

This PR adapts the at30tse75x temperature sensor to the new I2C api.
It can be tested using a samr21-xpro and an IO1 Xplained extension (requires #7588)

Issues/PRs references

#6577

@aabadie aabadie added Area: drivers Area: Device drivers TF: I2C Marks issues and PRs related to the work of the I²C rework task force labels May 29, 2018
@haukepetersen haukepetersen mentioned this pull request May 29, 2018
Closed
47 tasks
@aabadie aabadie added the Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. label May 29, 2018
@aabadie aabadie force-pushed the new_i2c_if_at30tse branch from 242c136 to 8bd270d Compare June 7, 2018 21:17
@aabadie aabadie force-pushed the new_i2c_if_at30tse branch from 8bd270d to 38ad2d3 Compare June 18, 2018 11:31
dylad
dylad approved these changes Jul 4, 2018
View reviewed changes
Copy link
Member

@dylad dylad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested ACK.
Look good, @aabadie can you share some results outputs or if someone can confirm this driver still works it would be great.

@aabadie
Copy link
Contributor Author

aabadie commented Jul 4, 2018

The Io1 Xplained extension meta-driver was broken. I just pushed a fix.

Otherwise, here is the output of the at30tse75x shell command:

reboot
main(): This is RIOT! (Version: 2018.07-devel-299-g38ad2-trek-saclay-new_i2c_if_at30tse)
Welcome to RIOT!

Type `help` for help, type `saul` to see all SAUL devices

> at30tse75x init 0
at30tse75x init 0
Initialized AT30TSE75x sensor on I2C #0 @ 0x4f
> at30tse75x read
at30tse75x read
Temperature: 28.500 °C
> at30tse75x read
at30tse75x read
Temperature: 29.000 °C
> at30tse75x read
at30tse75x read
Temperature: 28.500 °C
>

I verified the io1 Xplained extension on iotlab, it also works.

@dylad
Copy link
Member

dylad commented Jul 4, 2018

Then here we go

@dylad dylad merged commit 4266045 into RIOT-OS:new_i2c_if Jul 4, 2018
basilfx pushed a commit to basilfx/RIOT that referenced this pull request Jul 10, 2018
@dylad @basilfx
Merge pull request RIOT-OS#9229 from aabadie/new_i2c_if_at30tse
ad05f2f 
drivers/at30tse75x: adapt to new I2C api
dylad added a commit to dylad/RIOT that referenced this pull request Jul 10, 2018
@dylad
Merge pull request RIOT-OS#9229 from aabadie/new_i2c_if_at30tse
8497cdb 
drivers/at30tse75x: adapt to new I2C api
dylad added a commit that referenced this pull request Jul 11, 2018
@dylad
Merge pull request #9229 from aabadie/new_i2c_if_at30tse
c394423 
drivers/at30tse75x: adapt to new I2C api
@aabadie aabadie added this to the Release 2018.10 milestone Nov 5, 2018
@aabadie aabadie deleted the new_i2c_if_at30tse branch January 15, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylad dylad dylad approved these changes

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. TF: I2C Marks issues and PRs related to the work of the I²C rework task force
Projects
None yet
Milestone
Release 2018.10
Development

Successfully merging this pull request may close these issues.
2 participants
@aabadie @dylad