adcxx1c: adapt to new i2c API #9210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 tasks
404415b to
37d96d4
Compare
smlng
suggested changes
Jun 28, 2018
drivers/adcxx1c/adcxx1c.c
Outdated
| @@ -79,7 +71,7 @@ int adcxx1c_read_raw(const adcxx1c_t *dev, int16_t *raw) | |||
| int status; | |||
|
|
|||
| i2c_acquire(I2C); | |||
| status = i2c_read_regs(I2C, ADDR, ADCXX1C_CONV_RES_ADDR, buf, 2); | |||
| status = i2c_read_regs(I2C, ADDR, ADCXX1C_CONV_RES_ADDR, buf, 2, 0); | |||
| i2c_release(I2C); | |||
| if (status < 2) { | |||
There was a problem hiding this comment.
the function does not return the read bytes anymore, but 0 on success
|
@vincent-d do you think you can addressed the comments soon ? |
37d96d4 to
2ad23fd
Compare
|
Sorry for the delay, my last 2 weeks have been busy. Comment addressed. |
smlng
approved these changes
Jul 9, 2018
|
please squash |
2ad23fd to
bcd6619
Compare
|
Squashed |
|
Thanks @vincent-d ! |
basilfx
pushed a commit
to basilfx/RIOT
that referenced
this pull request
Jul 10, 2018
adcxx1c: adapt to new i2c API
dylad
added a commit
to dylad/RIOT
that referenced
this pull request
Jul 10, 2018
adcxx1c: adapt to new i2c API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Adapt adcxx1c driver to new i2c API.
Issues/PRs references
#6577