-
Notifications
You must be signed in to change notification settings - Fork 2.1k
cpu: ldscript memory attribute corrections #9089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6df8d97
to
611729a
Compare
kYc0o
approved these changes
May 7, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. Though the extra sections in some ldscripts are not used, I agree the most important it's the (!rx)
field.
611729a
to
35eeac1
Compare
35eeac1
to
19061b2
Compare
19061b2
to
9860004
Compare
This was referenced May 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
CI: run tests
If set, CI server will run tests on hardware for the labeled PR
Platform: ARM
Platform: This PR/issue effects ARM-based platforms
Type: cleanup
The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Using attributes (rx) on only the ROM segment will make the linker use that segment for orphan sections with read-only or executable contents.
Having a correct default placement for read-only and executable sections makes it easier to write augmentation ldscripts for adding more sections, such as XFA (#7523), because the linker will then place any added sections in ROM.
Any writable sections which need relocating during boot still needs the
> ram AT> rom
specifications like it is done in the platform specific ldscripts.Quote GNU ld manual https://sourceware.org/binutils/docs/ld/MEMORY.html
Issues/PRs references
based on #9084
useful in #7523
https://sourceware.org/binutils/docs/ld/MEMORY.html