-
Notifications
You must be signed in to change notification settings - Fork 2.1k
driver/bme680: add support for BME680 sensor #9909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: dylad <dylan.laduranty@mesotic.com>
c3d39d6
to
1708b25
Compare
@dylad, I didn't went through all the changes here yet but I had a look at the Bosch original driver. One thing I like there is that they provide a generic implementation, agnostic to the underlying hardware API: one can provide the SPI/I2C read/write functions to the driver and it does the job. |
I can work on providing an external package but we will loose the benefit of the SAUL implementation and TBH I don't like the way Bosch wrote this driver :) |
After some changes, I could also contribute a BME680 device driver, which I wrote completely from scratch almost a year ago for ESP-IDF and esp-open-rtos (https://github.com/gschorcht/bme680-esp-idf). It is working with SPI and I2C as well. It supports all complex features and configurations of the sensor. My plan was to work on it in a few days to port it to RIOT but now I have seen this PR and I wonder if it still makes sense. |
After thinking about it, maybe @aabadie is right. I'll provide this driver as a pkg, this way, we will let @boschsensortec maintaining their little toy and we will avoid this 'burden'. |
Contribution description
This PR brings support for BME680 sensor (I2C only), this sensor can measure temperature, humidity, pressure and some gas concentration. This driver is based on Bosch Sensortech driver [1]
Maybe @aabadie will be interested by this driver ?
This PR still need some cleanup, this is why a set the WIP label, but it works in the current state.
Testing procedure
Run tests/driver_bme680 and check the displayed results
Issues/PRs references
None.
[1] https://github.com/BoschSensortec/BME680_driver