makefiles/buildtests.inc.mk: allow overwriting make output redirection #9741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running tests, I often needed to modify `buildtests.inc.mk` to see the
actual errors/standard output.
This allows overwriting the default redirection of both to `/dev/null`.
It is low level and directly given to the command execution.
As it is interpreted by make, it can even be overwritten using build system
variables:
'BUILDTEST_MAKE_REDIRECT=>/tmp/buildtest.$${board}.out 2>&1'
smlng
suggested changes
Aug 10, 2018
There was a problem hiding this comment.
I tested in macOS and it did not work as expected.
My command run from RIOT root
BUILDTEST_MAKE_REDIRECT=>/tmp/buildtest.$${board}.out 2>&1 make -C tests/minimal/ buildtest
but there was only one file in /tmp with name buildtest.53771{board}.out, because the $$ gives you the pid. I guess some escaping is needed?
|
ah when I do it works |
smlng
approved these changes
Aug 10, 2018
|
Thanks for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
When running tests, I often needed to modify
buildtests.inc.mkto see theactual errors/standard output.
This allows overwriting the default redirection of both to
/dev/null.It is low level and directly given to the command execution.
As it is interpreted by make, it can even be overwritten using build system
variables:
Issues/PRs references
I needed something like this when running
buildtestfor the release tests.