Skip to content

drivers/jc42: adapt to new i2c API #9492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2018
Merged

drivers/jc42: adapt to new i2c API #9492

merged 1 commit into from
Jul 5, 2018

Conversation

MichelRottleuthner
Copy link
Contributor

Contribution description

This adapts the jc42 driver to the new i2c api. I don't have hardware to test.

Issues/PRs references

#6577

@MichelRottleuthner MichelRottleuthner added Area: drivers Area: Device drivers TF: I2C Marks issues and PRs related to the work of the I²C rework task force labels Jul 4, 2018
@haukepetersen haukepetersen mentioned this pull request Jul 4, 2018
Closed
47 tasks
@aabadie aabadie requested a review from bergzand July 4, 2018 08:16
@aabadie
Copy link
Contributor

aabadie commented Jul 4, 2018

I think @bergzand might be able to test, since he initially contributed this driver.

@bergzand
Copy link
Member

bergzand commented Jul 4, 2018

I don't mind testing this, but I have to check if I currently have access to the hardware.

smlng
smlng approved these changes Jul 5, 2018
View reviewed changes
Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested ACK, good changes look good.

@smlng
Copy link
Member

smlng commented Jul 5, 2018

please rebase onto new_i2c_if branch to get rid of the pn532 error

@MichelRottleuthner
Copy link
Contributor Author

rebased

@smlng smlng merged commit a0f30e1 into RIOT-OS:new_i2c_if Jul 5, 2018
basilfx pushed a commit to basilfx/RIOT that referenced this pull request Jul 10, 2018
@smlng @basilfx
Merge pull request RIOT-OS#9492 from MichelRottleuthner/pr_jc42_new_i2c
6160b23 
drivers/jc42: adapt to new i2c API
dylad pushed a commit to dylad/RIOT that referenced this pull request Jul 10, 2018
@smlng @dylad
Merge pull request RIOT-OS#9492 from MichelRottleuthner/pr_jc42_new_i2c
fbf8357 
drivers/jc42: adapt to new i2c API
dylad pushed a commit that referenced this pull request Jul 11, 2018
@smlng @dylad
Merge pull request #9492 from MichelRottleuthner/pr_jc42_new_i2c
4c43230 
drivers/jc42: adapt to new i2c API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergzand bergzand Awaiting requested review from bergzand

1 more reviewer

@smlng smlng smlng approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Area: drivers Area: Device drivers TF: I2C Marks issues and PRs related to the work of the I²C rework task force
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MichelRottleuthner @aabadie @bergzand @smlng