Skip to content

gnrc_sixlowpan_frag: add page context to reassembly buffer #9482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2018
Merged

gnrc_sixlowpan_frag: add page context to reassembly buffer #9482

merged 1 commit into from
Jul 24, 2018

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jul 3, 2018 •
edited
Loading

Contribution description

While refactoring IPHC I noticed that the page actually can already be used for fragmentation: Given @cgundogan's work on ICN LoWPAN we can already assume, that the page context may (among other thing) determine the type of the reassembled packet. This PR provides the basis for that.

Issues/PRs references

None

@miri64
gnrc_sixlowpan_frag: add page context to reassembly buffer
8721d0b 
While refactoring IPHC I noticed that the page actually can already be
used for fragmentation: Given @cgundogan's work on [ICN LoWPAN] we can
already assume, that the page context may (among other thing) determine
the type of the reassembled packet. This PR provides the basis for
that.

[ICN LoWPAN]: https://tools.ietf.org/html/draft-gundogan-icnrg-ccnlowpan-01
@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking GNRC labels Jul 3, 2018
@miri64 miri64 requested a review from cgundogan July 3, 2018 12:33
@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 3, 2018
@miri64 miri64 force-pushed the gnrc_sixlowpan_frag/enh/pages branch from 55532b7 to 8721d0b Compare July 3, 2018 12:47
@miri64 miri64 mentioned this pull request Jul 3, 2018
Merged
cgundogan
cgundogan approved these changes Jul 24, 2018
View reviewed changes
Copy link
Member

@cgundogan cgundogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the testbed. Reassembly still works. ACK.

@cgundogan cgundogan added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 24, 2018
@cgundogan cgundogan merged commit 0dc02d9 into RIOT-OS:master Jul 24, 2018
@miri64 miri64 deleted the gnrc_sixlowpan_frag/enh/pages branch July 24, 2018 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgundogan cgundogan cgundogan approved these changes

Assignees
No one assigned
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miri64 @cgundogan