Skip to content

Conversation

Hyungsin
Copy link

@Hyungsin Hyungsin commented Jun 28, 2018

Contribution description

HDC1000 driver adaptation for i2c refactoring.

Issues/PRs references

#6577

@dylad
Copy link
Member

dylad commented Jun 28, 2018

Thanks of lot for handling this @Hyungsin !
First round of review :
line 95 and 112 need to be adapt as well.

@Hyungsin Hyungsin force-pushed the forupstream_hdc_i2c branch from a0f4bfe to 63e9a6d Compare June 28, 2018 19:33
@Hyungsin
Copy link
Author

@dylad, done 👍

@dylad dylad added Area: drivers Area: Device drivers TF: I2C Marks issues and PRs related to the work of the I²C rework task force labels Jun 28, 2018
@dylad
Copy link
Member

dylad commented Jun 28, 2018

Good job @Hyungsin, it looks good !
It would be great if someone can test it now so we can merge it.

Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK, used board pba-d-01-kw2x and the driver test: output okay does react to manipulation, i.e. breath onto it 🌬

@smlng smlng merged commit 9849406 into RIOT-OS:new_i2c_if Jun 29, 2018
@Hyungsin Hyungsin deleted the forupstream_hdc_i2c branch June 29, 2018 17:24
basilfx pushed a commit to basilfx/RIOT that referenced this pull request Jul 10, 2018
dylad pushed a commit to dylad/RIOT that referenced this pull request Jul 10, 2018
dylad pushed a commit that referenced this pull request Jul 11, 2018
drivers/hdc1000: adapt to new i2c API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: drivers Area: Device drivers TF: I2C Marks issues and PRs related to the work of the I²C rework task force
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants