Skip to content

drivers/kw2xrf: finish ongoing transmission before sending next frame #8304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2018
Merged

drivers/kw2xrf: finish ongoing transmission before sending next frame #8304

merged 1 commit into from
Jan 9, 2018

Conversation

PeterKietzmann
Copy link
Member

Contribution description

As described in below referenced issues, the KW2XRF driver currently does not wait for ongoing transmissions to finish before sending a next frame. If the device is busy, the second frame will simply be ignored. Problems usually occur with 6LoWPAN-fragmented IPv6 packets. This PR provides a fix. Now ping6 between a Phytec node an Atmel node with payloads up to 900.

@gebart I added you as author because this is actually your solution from #7107. D'accord?

Issues/PRs references

(Partly) fixes #4822; relates to #7474; fix taken from #7107

@PeterKietzmann PeterKietzmann added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Dec 20, 2017
@PeterKietzmann PeterKietzmann added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Dec 20, 2017
@jnohlgard jnohlgard self-assigned this Dec 20, 2017
@jnohlgard
Copy link
Member

I can't test on actual hardware because I don't have a phytec board, but I will do a review

@smlng smlng self-assigned this Dec 21, 2017
@smlng smlng added this to the Release 2018.01 milestone Dec 21, 2017
@smlng
Copy link
Member

smlng commented Dec 21, 2017

tested with 2 PhyNodes: works like charm. Even with remote-rev there is an improvement, but cannot get beyond 90B pings -> buts a problem with the remotes.

smlng
smlng approved these changes Dec 21, 2017
View reviewed changes
Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK.

@miri64 miri64 merged commit 9c1b6bd into RIOT-OS:master Jan 9, 2018
@miri64 miri64 mentioned this pull request Jan 10, 2018
Closed
@PeterKietzmann PeterKietzmann mentioned this pull request Feb 4, 2019
Merged
@maribu maribu mentioned this pull request Feb 12, 2019
Closed
@PeterKietzmann PeterKietzmann deleted the pr_drivers_kw2x_txbusy branch March 4, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnohlgard jnohlgard Awaiting requested review from jnohlgard

1 more reviewer

@smlng smlng smlng approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jnohlgard jnohlgard

@smlng smlng

Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2018.01
Development

Successfully merging this pull request may close these issues.

kw2xrf: packet loss when packets get fragmented
4 participants
@PeterKietzmann @jnohlgard @smlng @miri64