Skip to content

drivers/mag3110: apply unified params definition scheme #8758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 4, 2018
Merged

drivers/mag3110: apply unified params definition scheme #8758

merged 3 commits into from
Jul 4, 2018

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Mar 8, 2018 •
edited
Loading

Contribution description

This PR update the params definitions scheme for this device driver.
Also forgot this one last week.

Issues/PRs references

Initially done in #7937 and related to #7519

#6577

@aabadie aabadie added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 8, 2018
aabadie
aabadie commented May 22, 2018
View reviewed changes
Copy link
Contributor Author

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyone for reviewing this, it should be fast @miri64 ?

@aabadie aabadie mentioned this pull request May 23, 2018
Closed
@haukepetersen haukepetersen mentioned this pull request May 25, 2018
Closed
47 tasks
@aabadie aabadie force-pushed the pr/drivers/params/mag3110 branch from 0582e86 to 6264419 Compare June 7, 2018 21:44
@smlng
Copy link
Member

smlng commented Jun 29, 2018

@aabadie please rebase and do you want to add I2C API adaption, too? This one is missing for the I2C rework but this PR is referenced anyway. However, then please rebase onto new_i2c_if branch, first.

@aabadie aabadie force-pushed the pr/drivers/params/mag3110 branch from 6264419 to 45a8a83 Compare June 29, 2018 13:52
@aabadie aabadie changed the base branch from master to new_i2c_if June 29, 2018 13:52
@aabadie
Copy link
Contributor Author

aabadie commented Jun 29, 2018

The work was already done, but I forgot to push it and to change the base branch...

@aabadie aabadie removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 2, 2018
@aabadie aabadie force-pushed the pr/drivers/params/mag3110 branch from 45a8a83 to a73efed Compare July 2, 2018 06:44
@aabadie aabadie added the TF: I2C Marks issues and PRs related to the work of the I²C rework task force label Jul 2, 2018
smlng
smlng approved these changes Jul 4, 2018
View reviewed changes
Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK, used pba-d-01-kw2x with onboard sensor

@aabadie aabadie merged commit 47b4c22 into RIOT-OS:new_i2c_if Jul 4, 2018
basilfx pushed a commit to basilfx/RIOT that referenced this pull request Jul 10, 2018
@aabadie @basilfx
Merge pull request RIOT-OS#8758 from aabadie/pr/drivers/params/mag3110
a1a1d51 
drivers/mag3110: apply unified params definition scheme
dylad pushed a commit to dylad/RIOT that referenced this pull request Jul 10, 2018
@aabadie @dylad
Merge pull request RIOT-OS#8758 from aabadie/pr/drivers/params/mag3110
5c0f714 
drivers/mag3110: apply unified params definition scheme
dylad pushed a commit that referenced this pull request Jul 11, 2018
@aabadie @dylad
Merge pull request #8758 from aabadie/pr/drivers/params/mag3110
bc7bb64 
drivers/mag3110: apply unified params definition scheme
@aabadie aabadie deleted the pr/drivers/params/mag3110 branch September 23, 2018 08:47
@aabadie aabadie added this to the Release 2018.10 milestone Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@smlng smlng smlng approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Area: drivers Area: Device drivers TF: I2C Marks issues and PRs related to the work of the I²C rework task force Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2018.10
Development

Successfully merging this pull request may close these issues.
2 participants
@aabadie @smlng