Skip to content

make: fix indention to 2 spaces in Makefile.dep #7065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2017
Merged

make: fix indention to 2 spaces in Makefile.dep #7065

merged 1 commit into from
May 16, 2017

Conversation

haukepetersen
Copy link
Contributor

1, 2, done (and not 3, 4).

If I remember correctly, we once decided to indent conditionals in Makefiles with two spaces, as 4 spaces are 'reserved' for rules...

@haukepetersen haukepetersen added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: build system Area: Build system labels May 16, 2017
@haukepetersen haukepetersen added this to the Release 2017.07 milestone May 16, 2017
@haukepetersen haukepetersen requested a review from miri64 May 16, 2017 08:41
@haukepetersen haukepetersen force-pushed the fix_makefiledep_indention branch from 0a3b55f to a8972ab Compare May 16, 2017 08:42
@miri64
Copy link
Member

miri64 commented May 16, 2017

as 4 spaces are 'reserved' for rules...

Not quite correct: rules only work with tabs and most people have tabs configured to be 4 spaces wide ;-)

miri64
miri64 approved these changes May 16, 2017
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 16, 2017
@miri64 miri64 merged commit b873eda into RIOT-OS:master May 16, 2017
@miri64 miri64 self-assigned this May 16, 2017
@haukepetersen haukepetersen deleted the fix_makefiledep_indention branch May 16, 2017 08:50
@aabadie aabadie mentioned this pull request Sep 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

Assignees

@miri64 miri64

Labels
Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2017.07
Development

Successfully merging this pull request may close these issues.
2 participants
@haukepetersen @miri64