Skip to content

board\samd21-xpro: Corrected SPI pins for EX3 Header #7025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2017
Merged

board\samd21-xpro: Corrected SPI pins for EX3 Header #7025

merged 1 commit into from
May 10, 2017

Conversation

kbumsik
Copy link
Contributor

@kbumsik kbumsik commented May 9, 2017 •
edited
Loading

I found the SPI mux definitions for EXT3 header were wrong. I tested using tests/driver_sdcard_spi.

This change is Reviewable

@aabadie aabadie added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels May 9, 2017
@aabadie aabadie added this to the Release 2017.07 milestone May 9, 2017
@aabadie
Copy link
Contributor

aabadie commented May 9, 2017

ping @travisgriggs, since you proposed the initial support, you are probably able to test ?

@travisgriggs
Copy link
Contributor

myself or @photonthunder

@kbumsik
Copy link
Contributor Author

kbumsik commented May 10, 2017

FYI, in the SAMD21 Datasheet, chater 6, page 23, you can easily see there is no MUX_C for PB22 and PB23. Assigning MUX_C is totally invalid.

aabadie
aabadie approved these changes May 10, 2017
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbumsik, thanks for the link to the datasheet. It makes totally sense.

ACK

@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 10, 2017
@haukepetersen
Copy link
Contributor

All green -> let's go.

@haukepetersen haukepetersen merged commit 4373ecd into RIOT-OS:master May 10, 2017
@kbumsik kbumsik mentioned this pull request Oct 8, 2017
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie approved these changes

Assignees

@haukepetersen haukepetersen

@aabadie aabadie

Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2017.07
Development

Successfully merging this pull request may close these issues.
4 participants
@kbumsik @aabadie @travisgriggs @haukepetersen