Skip to content

shell_commands: fix sc_gnrc_netif2 for MSP430 #7961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2017
Merged

shell_commands: fix sc_gnrc_netif2 for MSP430 #7961

merged 1 commit into from
Nov 17, 2017

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Nov 8, 2017 •
edited
Loading

This shell command does not work on MSP430 at the moment. This fixes it by not relying on out parameters.

This PR is part of the network layer remodelling effort:
PR dependencies

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) GNRC Platform: MSP Platform: This PR/issue effects MSP-based platforms Area: network Area: Networking labels Nov 8, 2017
@miri64 miri64 requested a review from smlng November 8, 2017 14:15
@miri64 miri64 mentioned this pull request Nov 8, 2017
Merged
28 tasks
@miri64 miri64 mentioned this pull request Nov 16, 2017
Merged
3 tasks
@bergzand
Copy link
Member

Is there a working build config to fit this on the IoT-lab WSN430 nodes? I'd like to test this, but I can't get the build small enough to fit in the nodes :(

@kYc0o
Copy link
Contributor

kYc0o commented Nov 16, 2017

Actually the port is broken, so even if you get something to fit in there it won't work...

@kYc0o
Copy link
Contributor

kYc0o commented Nov 16, 2017

If you just want to build it, use the z1.

@miri64
Copy link
Member Author

miri64 commented Nov 16, 2017

Is there a working build config to fit this on the IoT-lab WSN430 nodes? I'd like to test this, but I can't get the build small enough to fit in the nodes :(

@bergzand I guess you could try it on an z1 with the state of #7456 and with gnrc_ipv6_default instead of gnrc_ipv6_router_default (without RPL etc, of course)

@bergzand
Copy link
Member

Well, I was hoping to be able to test this on one of the IoT-lab nodes since I don't have any other access to an msp430 cpu. :(

smlng
smlng approved these changes Nov 16, 2017
View reviewed changes
Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, ACK!

sys/shell/commands/sc_gnrc_netif2.c
@@ -258,7 +258,7 @@ static void _print_netopt(netopt_t opt)
}
}

const char *_netopt_state_str[] = {
static const char *_netopt_state_str[] = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated, but fine!

@smlng smlng added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 16, 2017
@smlng smlng added this to the Release 2018.01 milestone Nov 16, 2017
@miri64 miri64 merged commit 7ecafb7 into RIOT-OS:gnrc_netif2_integration/master Nov 17, 2017
@miri64 miri64 deleted the shell_commands/fix/sc_netif2 branch November 17, 2017 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@smlng smlng smlng approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@smlng smlng

Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: MSP Platform: This PR/issue effects MSP-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2018.01
Development

Successfully merging this pull request may close these issues.
4 participants
@miri64 @bergzand @kYc0o @smlng