Skip to content

shell_commands: port ifconfig command for gnrc_netif2 #7404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2017
Merged

shell_commands: port ifconfig command for gnrc_netif2 #7404

merged 2 commits into from
Oct 10, 2017

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jul 25, 2017 •
edited
Loading

Does what it says on the bin (+ port auto_init_netdev_tap non-intrusively for testing).

Depends on #7370.

This PR is part of the network layer remodelling effort:
PR dependencies

@miri64 miri64 requested a review from aabadie July 25, 2017 10:10
@miri64 miri64 force-pushed the gnrc_netif2/feat/sc branch 2 times, most recently from b63c683 to 2f7f1f1 Compare July 30, 2017 18:44
miri64 added a commit to miri64/RIOT that referenced this pull request Jul 31, 2017
@miri64
Merge branch 'gnrc_netif2/feat/sc' (RIOT-OS#7404) into RIOT-OS#7424
99f5c7a
@miri64 miri64 force-pushed the gnrc_netif2/feat/sc branch from 2f7f1f1 to 40decbd Compare August 1, 2017 14:04
miri64 added a commit to miri64/RIOT that referenced this pull request Aug 1, 2017
@miri64
Merge branch 'gnrc_netif2/feat/sc' (RIOT-OS#7404) into RIOT-OS#7424
084d3d3
This was referenced Aug 2, 2017
Closed
Closed
@bergzand bergzand mentioned this pull request Aug 8, 2017
Closed
@miri64 miri64 force-pushed the gnrc_netif2/feat/sc branch from 40decbd to 6bdafbe Compare August 21, 2017 10:45
miri64 added a commit to miri64/RIOT that referenced this pull request Aug 21, 2017
@miri64
Merge branch 'gnrc_netif2/feat/new-netif-api-for-gnrc' (RIOT-OS#7370)…
1908487 
… into RIOT-OS#7404
@miri64
Copy link
Member Author

miri64 commented Aug 21, 2017

Rebased to current master and current dependencies

miri64 added a commit to miri64/RIOT that referenced this pull request Aug 21, 2017
@miri64
Merge branch 'gnrc_netif2/feat/sc' (RIOT-OS#7404) into RIOT-OS#7424
afc23eb
@miri64 miri64 force-pushed the gnrc_netif2/feat/sc branch from c75a035 to eb8a023 Compare October 6, 2017 11:49
miri64 added a commit to miri64/RIOT that referenced this pull request Oct 6, 2017
@miri64
Merge branch 'gnrc_netif2/feat/new-netif-api-for-gnrc' (RIOT-OS#7370)…
17e1239 
… into RIOT-OS#7404
@miri64
Copy link
Member Author

miri64 commented Oct 6, 2017

Rebased to current master and current dependencies

@miri64
Copy link
Member Author

miri64 commented Oct 6, 2017

Again..

@miri64 miri64 force-pushed the gnrc_netif2/feat/sc branch from eb8a023 to 5e81c93 Compare October 6, 2017 15:53
miri64 added a commit to miri64/RIOT that referenced this pull request Oct 6, 2017
@miri64
Merge branch 'gnrc_netif2/feat/new-netif-api-for-gnrc' (RIOT-OS#7370)…
0c224e3 
… into RIOT-OS#7404
@miri64 miri64 force-pushed the gnrc_netif2/feat/sc branch from 5e81c93 to 918fc7d Compare October 6, 2017 15:56
miri64 added a commit to miri64/RIOT that referenced this pull request Oct 6, 2017
@miri64
Merge branch 'gnrc_netif2/feat/sc' (RIOT-OS#7404) into RIOT-OS#7424
d2dfe6b
@miri64 miri64 force-pushed the gnrc_netif2/feat/sc branch from 918fc7d to a228df4 Compare October 10, 2017 08:38
miri64 added a commit to miri64/RIOT that referenced this pull request Oct 10, 2017
@miri64
Merge branch 'gnrc_netif2/feat/new-netif-api-for-gnrc' (RIOT-OS#7370)…
6b9dbe9 
… into RIOT-OS#7404
@miri64
Copy link
Member Author

miri64 commented Oct 10, 2017

And again...

miri64 added a commit to miri64/RIOT that referenced this pull request Oct 10, 2017
@miri64
Merge branch 'gnrc_netif2/feat/sc' (RIOT-OS#7404) into RIOT-OS#7424
cabde98
@miri64 miri64 force-pushed the gnrc_netif2/feat/sc branch from a228df4 to 930f2c5 Compare October 10, 2017 09:43
@miri64
Copy link
Member Author

miri64 commented Oct 10, 2017

Rebased to current master, no longer waiting for other PR

@miri64 miri64 added Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 10, 2017
@miri64 miri64 added the GNRC label Oct 10, 2017
miri64 added a commit to miri64/RIOT that referenced this pull request Oct 10, 2017
@miri64
Merge branch 'gnrc_netif2/feat/sc' (RIOT-OS#7404) into RIOT-OS#7424
b3a5410
@x3ro x3ro added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Oct 10, 2017
x3ro
x3ro suggested changes Oct 10, 2017
View reviewed changes
Copy link
Contributor

@x3ro x3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good mostly, but where is set mentioned. E.g. I only figured out through the source that I can do ifconfig 6 set key .... I've found that I can get the set usage with just running ifconfig <if> set without parameters, but ifconfig 6 help doesn't seem to mention set.

@miri64
Copy link
Member Author

miri64 commented Oct 10, 2017

Looks good mostly, but where is set mentioned. E.g. I only figured out through the source that I can do ifconfig 6 set key .... I've found that I can get the set usage with just running ifconfig <if> set without parameters, but ifconfig 6 help doesn't seem to mention set.

I'm not sure what you mean. If you type ifconfig help I get:

ifconfig help
ifconfig help
usage: ifconfig [<if_id>]
usage: ifconfig <if_id> set <key> <value>
      Sets an hardware specific specific value
      <key> may be one of the following
       * "addr" - sets (short) address
       * "addr_long" - sets long address
       * "addr_short" - alias for "addr"
       * "cca_threshold" - set ED threshold during CCA in dBm
       * "channel" - sets the frequency channel
       * "chan" - alias for "channel"
       * "csma_retries" - set max. number of channel access attempts
       * "encrypt" - set the encryption on-off
       * "hop_limit" - set hop limit
       * "hl" - alias for "hop_limit"
       * "key" - set the encryption key in hexadecimal format
       * "mtu" - IPv6 maximum transition unit
       * "nid" - sets the network identifier (or the PAN ID)
       * "page" - set the channel page (IEEE 802.15.4)
       * "pan" - alias for "nid"
       * "pan_id" - alias for "nid"
       * "power" - TX power in dBm
       * "retrans" - max. number of retransmissions
       * "src_len" - sets the source address length in byte
       * "state" - set the device state

usage: ifconfig <if_id> [-]{ack_req|autoack|autocca|csma|encrypt|mac_no_sleep|fwd|iphc|preload|promisc|raw|rtr_adv
usage: ifconfig <if_id> add [anycast|multicast|unicast] <ipv6_addr>[/prefix_len]
usage: ifconfig <if_id> del <ipv6_addr>

There is a really long nice section about set

@x3ro
Copy link
Contributor

x3ro commented Oct 10, 2017 •
edited
Loading

Oh seems like this is different when you type ifconfig 6 help. I always tried the latter.

@miri64
Copy link
Member Author

miri64 commented Oct 10, 2017

Will provide something

@miri64
Copy link
Member Author

miri64 commented Oct 10, 2017

Ok. I added a specific if-branch for help now (before it was just the default that caused the output, so it was just a coincident ifconfig help outputed actual help ;-))

@x3ro
Copy link
Contributor

x3ro commented Oct 10, 2017

🎉 squash please

@miri64 miri64 force-pushed the gnrc_netif2/feat/sc branch from 2dc8bb2 to 7682882 Compare October 10, 2017 18:11
@miri64
Copy link
Member Author

miri64 commented Oct 10, 2017

Done

@miri64 miri64 force-pushed the gnrc_netif2/feat/sc branch from 7682882 to 8c0e779 Compare October 10, 2017 18:13
@miri64 miri64 force-pushed the gnrc_netif2/feat/sc branch from 8c0e779 to 489a3cf Compare October 10, 2017 18:15
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 10, 2017
@miri64
Copy link
Member Author

miri64 commented Oct 10, 2017

The @ingroup auto_init_gnrc_netif change was already pointed out in a previous PR. I reverted that after your ACK. I hope that is ok.

@miri64 miri64 merged commit c8a0256 into RIOT-OS:master Oct 10, 2017
@miri64 miri64 deleted the gnrc_netif2/feat/sc branch October 10, 2017 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie Awaiting requested review from aabadie

1 more reviewer

@x3ro x3ro x3ro approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@aabadie aabadie

Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miri64 @x3ro @aabadie