gnrc_ipv6_nib: add neighbor cache component #6988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7080fa2 to
9148d06
Compare
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
May 1, 2017
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
May 1, 2017
5ba050a to
84535e5
Compare
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
May 5, 2017
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
May 5, 2017
|
Rebased to current master and depending PRs. |
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
May 5, 2017
2 tasks
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
May 9, 2017
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
May 16, 2017
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
May 22, 2017
607e21f to
b614563
Compare
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Jun 9, 2017
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Jun 9, 2017
|
Rebased and adapted to changes in #6325. Since this was a little bit fiddly I also squashed |
b614563 to
65ad5b5
Compare
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Jun 9, 2017
|
Rebased to current master and #6767. |
miri64
commented
Jun 9, 2017
| memcpy(entry->l2addr, nib->l2addr, nib->l2addr_len); | ||
| entry->l2addr_len = nib->l2addr_len; | ||
| #endif | ||
| *state = nib; |
There was a problem hiding this comment.
This can use _nib_nc_get(), I know. Will port ASAP.
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Jun 10, 2017
miri64
commented
Jun 23, 2017
| * | ||
| * @param[in] node On-link entry. | ||
| * @param[out] nce External representation of the neighbor cache | ||
| * representation. |
There was a problem hiding this comment.
Note to self: representation representation
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Jun 27, 2017
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Jun 30, 2017
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Aug 1, 2017
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Aug 18, 2017
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Aug 21, 2017
cgundogan
approved these changes
Oct 6, 2017
|
Looks good since my last review. Please squash. |
976b835 to
40be23b
Compare
|
Squashed. |
|
GO! |
|
\o/ |
1 similar comment
|
\o/ |
benpicco
reviewed
Sep 3, 2020
|
|
||
| DEBUG("nib: lookup ctx = %p, type = %u\n", (void *)ctx, type); | ||
| while (event != NULL) { | ||
| offset += event->event.offset; |
There was a problem hiding this comment.
Why is this adding up the offsets of all events up until the matching one?
What is this function doing?
There was a problem hiding this comment.
Because the offset of an event is referring to the event before, not the absolute offset.
benpicco
reviewed
Sep 3, 2020
| offset += event->event.offset; | ||
| if ((event->msg.type == type) && | ||
| ((ctx == NULL) || (event->msg.content.ptr == ctx))) { | ||
| return offset; |
There was a problem hiding this comment.
From my naive understanding I would expect
return event->event.offset;here
There was a problem hiding this comment.
That would just give an arbritrary offset to the event of the event that fires before event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the neighbor cache component of the NIB (see NDP model), aimed to replace
gnrc_ipv6_nc.Depends on
#6325(merged) and#6767(merged).This PR is part of the network layer remodelling effort:
