Skip to content

cpu/atmega2560: reworked UART driver #5026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

cpu/atmega2560: reworked UART driver #5026

wants to merge 4 commits into from

Conversation

haukepetersen
Copy link
Contributor

gets rid of unneccesary configuration stuff in the boards periph_conf, makes the UART configuration much easier and saves ~650 byte flash for the default example

@haukepetersen haukepetersen added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Platform: AVR Platform: This PR/issue effects AVR-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Mar 10, 2016
@haukepetersen haukepetersen added this to the Release 2016.04 milestone Mar 10, 2016
kYc0o
kYc0o reviewed Mar 10, 2016
View reviewed changes
cpu/atmega2560/include/atmega2560_regs.h
#define MEGA_UART1_BASE (uint16_t *)(&UCSR1A)
#define MEGA_UART2_BASE (uint16_t *)(&UCSR2A)
#define MEGA_UART3_BASE (uint16_t *)(&UCSR2A)
/** @} */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No extra parentheses required here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no really, but they won't hurt either -> will fix

@kYc0o
Copy link
Contributor

kYc0o commented Mar 10, 2016

can you rebase since #5014 was merged? :)

@haukepetersen
Copy link
Contributor Author

yepp

@haukepetersen
Copy link
Contributor Author

rebased

@haukepetersen
Copy link
Contributor Author

also added the missing parens

@kYc0o
Copy link
Contributor

kYc0o commented Mar 10, 2016

great thanks

@kYc0o
Copy link
Contributor

kYc0o commented Mar 10, 2016

is this normal?:

UART used for STDIO (the shell): UART_DEV(-1)

@kYc0o
Copy link
Contributor

kYc0o commented Mar 10, 2016

I'm trying to use tests/periph_uart and it freezes. After a reboot it prints trash, lots of trash :S

@kYc0o
Copy link
Contributor

kYc0o commented Mar 10, 2016

actually it is possible to initialise one UART but at the second one it freezes

@haukepetersen haukepetersen modified the milestones: Release 2016.07, Release 2016.04 Mar 21, 2016
@haukepetersen
Copy link
Contributor Author

still looking into this, but won't probably make it for the release, so putting this on the list for the next one...

@kYc0o
Copy link
Contributor

kYc0o commented Mar 21, 2016

seems reasonable :)

This was referenced Jun 7, 2016
Merged
Merged
kYc0o added a commit that referenced this pull request Jun 19, 2016
@kYc0o
Merge pull request #5537 from kYc0o/reworked_uart_wfix
2adf76c 
cpu/atmega2560: reworked UART (from #5026)
@PeterKietzmann
Copy link
Member

#5537 was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kYc0o kYc0o

Labels
Platform: AVR Platform: This PR/issue effects AVR-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haukepetersen @kYc0o @PeterKietzmann