Skip to content

pkg: provide sock support for lwIP #5802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

pkg: provide sock support for lwIP #5802

wants to merge 10 commits into from

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Sep 2, 2016 •
edited
Loading

Based on #5758 (merged) #5923.

TODO:

  • test UDP
  • port IP
  • test IP
  • port TCP
  • test TCP

@miri64 miri64 added Area: network Area: Networking State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: pkg Area: External package ports State: waiting for other PR State: The PR requires another PR to be merged first labels Sep 2, 2016
@miri64
Copy link
Member Author

miri64 commented Sep 2, 2016

I wonder: there is UDP-lite support by lwIP. Do we want a special sock_ interface for this or just use sock_udp? If yes, how do we distinguish the two?

@miri64
Copy link
Member Author

miri64 commented Sep 27, 2016

Rebased to current master to include changes from #5801.

@miri64 miri64 mentioned this pull request Sep 27, 2016
Merged
@miri64 miri64 force-pushed the pkg/feat/lwip-sock branch from 1384902 to 792e90d Compare October 4, 2016 13:48
@miri64
Copy link
Member Author

miri64 commented Oct 4, 2016

Rebased to master.

@miri64 miri64 force-pushed the pkg/feat/lwip-sock branch from 792e90d to 415fb84 Compare October 4, 2016 15:37
@miri64
Copy link
Member Author

miri64 commented Oct 4, 2016

Finally managed to finish up on lwip_sock_udp.

@miri64 miri64 force-pushed the pkg/feat/lwip-sock branch from 415fb84 to 6e299f7 Compare October 4, 2016 15:42
@miri64
Copy link
Member Author

miri64 commented Oct 4, 2016

Rebased to current master, since #5884 was merged.

@miri64 miri64 force-pushed the pkg/feat/lwip-sock branch from f904efa to ae41c15 Compare October 4, 2016 16:37
@miri64 miri64 mentioned this pull request Oct 6, 2016
Merged
@miri64
Copy link
Member Author

miri64 commented Oct 6, 2016

Just realized that maybe its a good idea to test IPv4 capabilities, too (send is not tested yet but will do tomorrow).

@miri64 miri64 force-pushed the pkg/feat/lwip-sock branch 6 times, most recently from 74e1057 to 81326ac Compare October 7, 2016 08:54
@miri64
Copy link
Member Author

miri64 commented Oct 7, 2016

Rebased to current master and ported sock_ip (+ provided IPv4 and IPv6 tests for both sock_udp and sock_ip)

@miri64
Copy link
Member Author

miri64 commented Oct 10, 2016

TCP port added. Will add some updates to the sock_tcp's doc as soon as I'm done preparing that PR. Then tests for lwip_sock_tcp.

@miri64 miri64 force-pushed the pkg/feat/lwip-sock branch from 0204aaa to 7006228 Compare October 11, 2016 15:22
@miri64
Copy link
Member Author

miri64 commented Oct 11, 2016

Rebased to current #5923.

@miri64
Copy link
Member Author

miri64 commented Oct 11, 2016 •
edited
Loading

Tests should be done by tomorrow. Didn't manage to test _sock_tcp__read/write yet, everything else is working like a charm.

@miri64
Copy link
Member Author

miri64 commented Oct 12, 2016

Tests for TCP are done \o/ (but no adaption to #5929 yet).

@miri64
Copy link
Member Author

miri64 commented Oct 12, 2016 •
edited
Loading

+ given the size this PR now got I'm thinking about splitting it according to its protocol implementations.

@miri64
Copy link
Member Author

miri64 commented Oct 12, 2016

(though it is mostly the tests that take so much loc)

@miri64 miri64 force-pushed the pkg/feat/lwip-sock branch from 7a7ebcf to 9a5ed7d Compare October 12, 2016 22:58
This was referenced Oct 12, 2016
Merged
Merged
Merged
@miri64
Copy link
Member Author

miri64 commented Oct 12, 2016

Superseded by #5936, #5937, #5938.

@miri64 miri64 closed this Oct 12, 2016
@miri64 miri64 deleted the pkg/feat/lwip-sock branch October 12, 2016 23:10
@miri64 miri64 mentioned this pull request Jan 13, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kaspar030 kaspar030

Labels
Area: network Area: Networking Area: pkg Area: External package ports State: waiting for other PR State: The PR requires another PR to be merged first State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miri64 @kaspar030