-
Notifications
You must be signed in to change notification settings - Fork 2.1k
correcting linker LTO flags on OSX #5794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8c7fcb9
to
9956790
Compare
ffunction-sections and fdata-sections are already set and -flto is set when the environment variable LTO=1 |
CFLAGS should be added to link flags. I think it was added some time ago, but I'm replying from the phone so I can't look up the source now. |
From what I found, CFLAGS are (somehow) added to LINKFLAGS for many boards, but not in native. But, as already said I'm not expert on compiler or linker options, plus not familiar with the internal details of RIOTs build system - maybe you can check on this later on, when you have a bigger screen and keyboard available? |
Ping! This isn't that hard, is it? Could we resolve it (very) soon, its an annoying bug when testing on macOS. |
I'm sorry, I will not be able to assist here for a few days. To anyone interested in this issue, feel free to dig through the makefiles, I suggest starting with |
That's what I did and - as said above - I found that for some boards CFLAGS are added to LINKFLAGS, but not for native, which this patch corrects. |
I can also confirm this works. |
mhm, everybody seems happy - even Murdock, though this doesn't count in this case as it is OS X specific. Anyhow, I'll squash the 2 commits and then ACK + GO. |
5276288
to
168bd6f
Compare
- corrects and enhances changes introduced in RIOT-OS#5742
168bd6f
to
291c1a5
Compare
I'm reluctant to merge my own PR, I just tested it on OS X and Linux again: works for both. We can wait for Murdock to complete and then GO? |
Does anybody understand why Murdock fails building |
I believe the arduino error is unrelated to this PR and seem to be a race condition caused by using the application source directory as the destination for the _sketches.cpp file. |
The failing build is not related to this PR. The change looks OK and is confirmed working by maintainers above. ACK & go |
longer discussion here #5787, corrects some changes introduces in #5742 for OSX