make: distclean pkg sources on clean-intermediates target #5610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, it still builds. :) |
|
Yes, I'm just making a local test! |
|
It builds for me too, I tested with |
|
Hmmm I think not... can I run only one small test? Since the whole build can take very longtime I'm thinking in another testing way... |
|
untested ACK. I guess the successful Murdock build should be enough to tell it's working. |
|
I think the make target |
|
Great! thanks @gebart @kaspar030 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, "make clean-intermediates" ran "make clean" for each used package. That kept all the sources around. That breaks murdock with a full ramdisk, as each package source is kept around ~40 times, and our packages have ~40mb sources, leading to up to 1.6gb unused leftovers in the build ramdisk.
This PR makes "clean-intermediates" run "make distclean" for each used package.
I can't think of anything that would break, but please @ALL, take a thorough but quick look, so we can get murdock running again.