Skip to content

core: reduce types of tcb->status and tcb->priority #4924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2016
Merged

core: reduce types of tcb->status and tcb->priority #4924

merged 1 commit into from
Mar 2, 2016

Conversation

kaspar030
Copy link
Contributor

This PR changes the types of tcb->status and tcb->priority to uint8_t.

Together with #4557, #4923 and #3851, sizeof(tcb_t) is down from 44 to 12 bytes.

@kaspar030 kaspar030 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: core Area: RIOT kernel. Handle PRs marked with this with care! Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer labels Feb 29, 2016
@Kijewski
Copy link
Contributor

typedef uint8_t thread_status_t, thread_priority_t?

@OlegHahm
Copy link
Member

I'm surprised that we haven't changed this earlier.

@haukepetersen
Copy link
Contributor

ACK

@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 1, 2016
@OlegHahm
Copy link
Member

OlegHahm commented Mar 1, 2016

ACK

OlegHahm added a commit that referenced this pull request Mar 2, 2016
@OlegHahm
Merge pull request #4924 from kaspar030/smaller_core_types
76c397f 
core: reduce types of tcb->status and tcb->priority
@OlegHahm OlegHahm merged commit 76c397f into RIOT-OS:master Mar 2, 2016
@jnohlgard jnohlgard mentioned this pull request Mar 10, 2016
Merged
@kaspar030 kaspar030 deleted the smaller_core_types branch February 7, 2017 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@OlegHahm OlegHahm

Labels
Area: core Area: RIOT kernel. Handle PRs marked with this with care! CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaspar030 @Kijewski @OlegHahm @haukepetersen