make: actually make use of APPDEPS for building #4906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK. |
OlegHahm
added a commit
that referenced
this pull request
Mar 1, 2016
make: actually make use of APPDEPS for building
cladmi
added a commit
to cladmi/RIOT
that referenced
this pull request
Apr 13, 2018
According to the documentation, APPDEPS should not be added to BASELIBS as it
consists of make targets that should be executed
Files / Makefile targets that need to be created before the application can
be build. Set in the application's Makefile.
Reverts RIOT-OS#4906
This was referenced Apr 19, 2018
cladmi
added a commit
to cladmi/RIOT
that referenced
this pull request
May 3, 2018
According to the documentation, APPDEPS should not be added to BASELIBS as it
consists of make targets that should be executed
Files / Makefile targets that need to be created before the application can
be build. Set in the application's Makefile.
Reverts RIOT-OS#4906
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently the
APPDEPSvariable in the build system was not used to actually compile and link.