Skip to content

netdev2: add basic IEEE 802.15.4 support #4645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 15, 2016
Merged

netdev2: add basic IEEE 802.15.4 support #4645

merged 2 commits into from
Mar 15, 2016

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jan 16, 2016

Adds support for IEEE 802.15.4 to (gnrc_)netdev2.

Depends on #4636 (merged).

@miri64 miri64 added Area: network Area: Networking State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet State: waiting for other PR State: The PR requires another PR to be merged first labels Jan 16, 2016
@miri64 miri64 added this to the Release 2016.03 milestone Jan 16, 2016
This was referenced Jan 16, 2016
Merged
Merged
@miri64 miri64 force-pushed the netdev2/enh/ieee802154 branch 2 times, most recently from 98f7799 to 31a8d73 Compare January 18, 2016 15:23
@zhuoshuguo
Copy link
Contributor

@authmillenon Ping. A kind reminder for rebase.

@miri64
Copy link
Member Author

miri64 commented Jan 23, 2016

Why oO? There is no merge conflict.

@miri64
Copy link
Member Author

miri64 commented Jan 23, 2016

Ah this is about the Hack'n'ACK. I'm not sure this PR will leave WIP state until Tuesday, but I will try :-)

@zhuoshuguo
Copy link
Contributor

@authmillenon Yep, that is just kind a notice for the preparation of the Hack'n'ACK. :-) No problem, take your time.

@miri64 miri64 force-pushed the netdev2/enh/ieee802154 branch from 31a8d73 to 6688a6d Compare January 24, 2016 22:58
@miri64 miri64 added Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties and removed State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet labels Jan 24, 2016
@miri64 miri64 force-pushed the netdev2/enh/ieee802154 branch 2 times, most recently from a7acfe5 to b2376dc Compare January 24, 2016 23:04
@miri64
Copy link
Member Author

miri64 commented Jan 24, 2016

Rebased and squashed

@miri64 miri64 force-pushed the netdev2/enh/ieee802154 branch 2 times, most recently from 8d93a54 to 53bc5fb Compare January 25, 2016 00:32
@aeneby
Copy link
Member

aeneby commented Jan 25, 2016

Awesome idea. Would be great to have 802.15.4 frequency constants defined somewhere too (i.e. IEEE802154_{CHANNEL_SPACING,{MAX,MIN}_{CHANNEL,FREQ}}) Perhaps even some macros to convert freq<->channel?

@miri64
Copy link
Member Author

miri64 commented Jan 25, 2016

But that would go into #4636, right? This PR only introduces common option handling for IEEE 802.15.4 devices.

@miri64 miri64 mentioned this pull request Jan 25, 2016
Merged
@emmanuelsearch
Copy link
Member

Since #4636 is no longer H&A candidate, shall we remove the flag here too?

@miri64
Copy link
Member Author

miri64 commented Jan 26, 2016

Why was it closed oO?

@miri64 miri64 reopened this Jan 26, 2016
@miri64
Copy link
Member Author

miri64 commented Jan 26, 2016

And yes please.

@miri64 miri64 removed the Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties label Jan 26, 2016
@miri64 miri64 mentioned this pull request Mar 7, 2016
Closed
10 tasks
@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 7, 2016
@miri64
Copy link
Member Author

miri64 commented Mar 7, 2016

RIOT CI succeeds on fixup commit? Oo

@miri64
Copy link
Member Author

miri64 commented Mar 7, 2016

Nope… just the status is wrong ;-):

The following build groups had errors:
static-tests
cortex_m3_2
cortex_m3_1

@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 7, 2016
@kaspar030
Copy link
Contributor

I thought I fixed that, but I'm losing track of which PR's got queued when.

@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 7, 2016
@kaspar030
Copy link
Contributor

Uff. Finally it is erroring. :)

@haukepetersen
Copy link
Contributor

@authmillenon: could you squash?!

@miri64 miri64 force-pushed the netdev2/enh/ieee802154 branch from 64a5d8a to eb49123 Compare March 15, 2016 11:59
@miri64
Copy link
Member Author

miri64 commented Mar 15, 2016

Sure.

@haukepetersen
Copy link
Contributor

sys/net/gnrc/link_layer/netdev2/gnrc_netdev2_ieee802154.c:147: style (variableScope): The scope of the variable 'vector' can be reduced.

@miri64
Copy link
Member Author

miri64 commented Mar 15, 2016

Interesting. I have cppcheck running as a pre-commit hook, so it's curious this did not show up locally yet.

@miri64 miri64 force-pushed the netdev2/enh/ieee802154 branch from eb49123 to b0b76ba Compare March 15, 2016 16:11
@miri64
Copy link
Member Author

miri64 commented Mar 15, 2016

Fixed and squashed immediately.

@haukepetersen
Copy link
Contributor

ACK

@miri64
Copy link
Member Author

miri64 commented Mar 15, 2016

miri64 added a commit that referenced this pull request Mar 15, 2016
@miri64
Merge pull request #4645 from authmillenon/netdev2/enh/ieee802154
1caf0bc 
netdev2: add basic IEEE 802.15.4 support
@miri64 miri64 merged commit 1caf0bc into RIOT-OS:master Mar 15, 2016
@miri64 miri64 deleted the netdev2/enh/ieee802154 branch March 15, 2016 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kaspar030 kaspar030

Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2016.04
Development

Successfully merging this pull request may close these issues.
8 participants
@miri64 @zhuoshuguo @aeneby @emmanuelsearch @kaspar030 @haukepetersen @thomaseichinger @OlegHahm