Skip to content

core: rename tcb_t -> thread_t, move into thread.h #4578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 5, 2016
Merged

core: rename tcb_t -> thread_t, move into thread.h #4578

merged 8 commits into from
Mar 5, 2016

Conversation

kaspar030
Copy link
Contributor

Calling the struct "thread control block" seems outdated. This PR moves the definition into thread.h.

@kaspar030 kaspar030 added Area: core Area: RIOT kernel. Handle PRs marked with this with care! Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Jan 5, 2016
@haukepetersen
Copy link
Contributor

I like!

@Kijewski
Copy link
Contributor

Kijewski commented Jan 5, 2016

👍

@DipSwitch
Copy link
Member

1ste ACK in tha pocket

@haukepetersen
Copy link
Contributor

2nd ACK (once Travis is happy)

miri64
miri64 reviewed Jan 12, 2016
View reviewed changes
core/include/thread.h
* @brief Thread status list
* @{
*/
#define STATUS_NOT_FOUND (-1) /**< Describes an illegal thread status */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for just writing that now, but wouldn't a THREAD_ prefix on those be more in line with the coding conventions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's out of scope for this PR.

@OlegHahm OlegHahm added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 12, 2016
@kaspar030
Copy link
Contributor Author

Well, travis did not agree at all. ;)

  • factored out thread stacksize defines into "cpu_conf_common.h" for all cortex-M cpu's
  • fixed some includes

@DipSwitch @haukepetersen pls take another look...

@kaspar030 kaspar030 added this to the Release 2016.03 milestone Jan 14, 2016
@kaspar030
Copy link
Contributor Author

Sorry, there's more trouble.

@kaspar030 kaspar030 added the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Jan 15, 2016
DipSwitch
DipSwitch reviewed Feb 3, 2016
View reviewed changes
core/include/thread.h
clist_node_t rq_entry; /**< run queue entry */

void *wait_data; /**< holding messages */
priority_queue_t msg_waiters; /**< threads waiting on message */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the comment alignment should be fixed?

@DipSwitch
Copy link
Member

Just a few comment alignment stuff, not that it must be fixed by me. But it would look better ;)

The code seems fine, ACK

@kaspar030 kaspar030 force-pushed the refactor_tcb_into_thread branch from 6fc2941 to 4cbe9e8 Compare February 22, 2016 00:12
@OlegHahm OlegHahm added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Feb 22, 2016
@OlegHahm
Copy link
Member

What's up with this PR?

@kaspar030
Copy link
Contributor Author

I've rebased it yesterday and (hopefully) just fixed the last compile problem.

I'll unmark it WIP.
Someone should take a look at the new cpu_cortex_common.h, I had to change the include order slightly. @haukepetersen ?

@kaspar030 kaspar030 removed the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Feb 22, 2016
@OlegHahm OlegHahm added the Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties label Feb 27, 2016
@kaspar030 kaspar030 force-pushed the refactor_tcb_into_thread branch 2 times, most recently from 9c5380a to 06a9efc Compare February 29, 2016 23:15
@haukepetersen
Copy link
Contributor

please reomve the stack size defines from the cortexm_common/include/cpu.h, otherwise they are twice defined for cortex MCUs...

@haukepetersen
Copy link
Contributor

otherwise looks good, please squash!

@kaspar030 kaspar030 force-pushed the refactor_tcb_into_thread branch from 06a9efc to 5dbacf0 Compare March 1, 2016 15:37
@kaspar030
Copy link
Contributor Author

  • addressed, squashed

@haukepetersen haukepetersen removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Mar 1, 2016
@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR State: waiting for other PR State: The PR requires another PR to be merged first and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR State: waiting for other PR State: The PR requires another PR to be merged first labels Mar 5, 2016
@kaspar030 kaspar030 force-pushed the refactor_tcb_into_thread branch from 90358e3 to ed03204 Compare March 5, 2016 17:22
@kaspar030
Copy link
Contributor Author

  • removed riot ci dependencies

@kaspar030
Copy link
Contributor Author

Bascally three ACKs -> go!

kaspar030 added a commit that referenced this pull request Mar 5, 2016
@kaspar030
Merge pull request #4578 from kaspar030/refactor_tcb_into_thread
910290c 
core: rename tcb_t -> thread_t, move into thread.h
@kaspar030 kaspar030 merged commit 910290c into RIOT-OS:master Mar 5, 2016
@kaspar030 kaspar030 deleted the refactor_tcb_into_thread branch March 5, 2016 20:15
@Yonezawa-T2 Yonezawa-T2 mentioned this pull request Mar 7, 2016
Closed
@jnohlgard jnohlgard mentioned this pull request Mar 10, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@haukepetersen haukepetersen

Labels
Area: core Area: RIOT kernel. Handle PRs marked with this with care! CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2016.04
Development

Successfully merging this pull request may close these issues.
6 participants
@kaspar030 @haukepetersen @Kijewski @DipSwitch @OlegHahm @miri64