Skip to content

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Dec 14, 2015

Another one in #4309 bites the dust ;-)

@miri64 miri64 added the Area: doc Area: Documentation label Dec 14, 2015
@miri64 miri64 added this to the Release 2015.12 milestone Dec 14, 2015
@OlegHahm OlegHahm mentioned this pull request Dec 14, 2015
24 tasks
@miri64
Copy link
Member Author

miri64 commented Dec 14, 2015

Or maybe @kaspar030 want's to review?

@miri64 miri64 assigned kaspar030 and unassigned OlegHahm Dec 14, 2015
[TOC]

To create your own application you need to create a directory contating some
from the C file(s) containing your source code and a Makefile. A template
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"... some of ...", but I'd drop that and just write "you need to create a directory contating the C file(s) containing your source code and a Makefile"

Also "s/contaiting/containing".

@kaspar030
Copy link
Contributor

I'm on arch, so I cannot test doxygen. Text looks fine!

@miri64
Copy link
Member Author

miri64 commented Dec 14, 2015

In pure markdown should work. The bug only is apparent with block-comments:

~~~~~~~~
some code
~~~~~~~~

vs

/**
 * ~~~~~~~
 * some code
 * ~~~~~~~
 */

@miri64
Copy link
Member Author

miri64 commented Dec 14, 2015

Addressed comments.

@miri64
Copy link
Member Author

miri64 commented Dec 14, 2015

Addressed comments

that you may want to use `$(CURDIR)` here, to give a relative path)

The `BOARD` macro is also required and recommended to be set to `native` per
default, but is recommended to be overridable with the `?=` operator.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: I think “by default” reads more smoothly :D

@Lotterleben
Copy link
Member

Just plopping by to say I think this is awesome. <3

=================
After the board is initialized, RIOT starts two threads: the idle thread and
the main thread. The idle thread has the lowest priority and will run whenever
no other thread is ready to run. It will automatically use the lowest possible
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that's the plan but not really the fact I guess :/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Documentation is also specification, not just fact stating" I counter to that ^^

@PeterKietzmann
Copy link
Member

Again: Thanks Martine for taking the initiative :-) !

==========================
The minimal Makefile {#the-minimal-makefile}
--------------------
At minimum the Makefile of an application (see @ref getting-started) needs to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to "define" the macros, right?

@PeterKietzmann
Copy link
Member

Besides the minor comments: I like the your documentation enhancement

@miri64
Copy link
Member Author

miri64 commented Dec 15, 2015

Addressed comments

@PeterKietzmann
Copy link
Member

Well, ACK (when squashed) from my side. @kaspar030 might also want to check and push the merge button then

@miri64 miri64 force-pushed the doc/enh/creating-application branch from cc37665 to 31702f3 Compare December 15, 2015 10:56
@miri64
Copy link
Member Author

miri64 commented Dec 15, 2015

Squashed

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 16, 2015
@miri64
Copy link
Member Author

miri64 commented Dec 16, 2015

Static tests pass, other stuff is not touched => go.

miri64 added a commit that referenced this pull request Dec 16, 2015
doc: add page about creating an application
@miri64 miri64 merged commit c57b33e into RIOT-OS:master Dec 16, 2015
@miri64 miri64 deleted the doc/enh/creating-application branch December 16, 2015 21:38
@OlegHahm OlegHahm added the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Dec 17, 2015
@cgundogan cgundogan removed the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Apr 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants